Error
MediaWiki version: n/a
message
Uncaught TypeError: Cannot read property 'length' of null
Description
Description
Details
Details
- Request ID
- AXQxc0pMNoG2jwpwrOQV
- Request URL
- https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.08.27/clienterror?id=AXQxc0pMNoG2jwpwrOQV&_g=h@05d81a8
Stack Trace
exception.trace
at VeUiFindAndReplaceDialog.ve.ui.FindAndReplaceDialog.renderRangeOfFragments https://ca.wikipedia.org/w/load.php?lang=ca&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2Cicons%2Clanguage%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector&version=zd0la:822:690 at VeUiFindAndReplaceDialog.ve.ui.FindAndReplaceDialog.renderFragments https://ca.wikipedia.org/w/load.php?lang=ca&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2Cicons%2Clanguage%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector&version=zd0la:821:843 at run https://ca.wikipedia.org/w/load.php?lang=ca&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%2Csite&skin=vector&version=1pfn7:157:645
Related Changes in Gerrit:
Customize query in gerrit
Related Objects
Related Objects
- Mentioned In
- T255617: TypeError: rects is null (from VE FindAndReplaceDialog)
T260212: TypeError: dimensions is null - Mentioned Here
- rGVED0a5e284c7fd0: Revert "ve.ce.Surface: Debounce onModelDocumentUpdate"
rGVED22a771930320: Merge "More direct fix for find-and-replace running after teardown issues"
rGVED9534694b4576: Merge "Follow-up I1361852: Make docs writable when finished"
rGVEDb49db9a5b56c: Update treeDiffer to 1.0.2
Event Timeline
Comment Actions
Change 623069 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] FindAndReplace: Guard against getSelectionRects failing
Comment Actions
I couldn't reproduce this, but as the offending path tried to build a DOM range from a selection on a debounced event, I can see how that could result in the DOM range not being able to be constructed. Absent of reports of the dialog not behaving properly, I think it's fine to just give up if the rects can't be generated
Comment Actions
Change 623069 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] FindAndReplace: Guard against getSelectionRects failing
Comment Actions
As we couldn't reproduce this, there is nothing to test. Hopefully it will stop appearing in the error logs.
Comment Actions
Change 623875 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b49db9a5b)
Comment Actions
Change 623875 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (9534694b4)
Comment Actions
These are probably all the same error (the error messages are different because they're generated by different browsers). The fix is only getting deployed this week, because there was no deployment train last week.
Comment Actions
Change 626476 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] More direct fix for find-and-replace running after teardown issues
Comment Actions
Change 626476 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] More direct fix for find-and-replace running after teardown issues
Comment Actions
Change 626737 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (22a771930)
Comment Actions
Change 626737 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (22a771930)
Comment Actions
Chart for "Cannot read property 'length' of null": https://logstash.wikimedia.org/goto/5a0da0e3d8cf553a614442893d8145ff (there is more noise, there are probably other errors with the same message)
It looks like the "More direct fix" (https://gerrit.wikimedia.org/r/626476) regressed the issue.
At first the errors disappeared between 2020-09-09 and 2020-09-16 (corresponding to the first patch https://gerrit.wikimedia.org/r/623069), then reappeared (corresponding to https://gerrit.wikimedia.org/r/626476).
Chart for "rects is null": https://logstash.wikimedia.org/goto/91e5fcdf5bd39363519d06086f659b0e
Chart for "Cannot read property 'length' of null": https://logstash.wikimedia.org/goto/5a0da0e3d8cf553a614442893d8145ff (there is more noise, there are probably other errors with the same message)
Comment Actions
Change 629214 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Restore check for getSelectionRects returning null
Comment Actions
Change 629214 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Restore check for getSelectionRects returning null
Comment Actions
Change 629450 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0a5e284c7)
Comment Actions
Change 629450 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0a5e284c7)
Comment Actions
I think this also shows up as` TypeError: rect is null` https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.10.14/clienterror/?id=AXUoB4XL2lgCwKx7G3H8
Comment Actions
Stopped occurring after 13 October.
"rects.length": https://logstash.wikimedia.org/goto/d3fc8c9caa6ebeace47854fc2b397a0b
"Cannot read property 'length' of null": https://logstash.wikimedia.org/goto/d7479784897998032da012bd44ae07f2
(the same error message can easily occur for unrelated problems, and it still appears, but at greatly reduced volume)
"rects is null": https://logstash.wikimedia.org/goto/a68b172beab3d9751f336990a6b08986
