Page MenuHomePhabricator
Create Task
Maniphest T261634

Typing is slow on very long documents
Closed, ResolvedPublic
Actions

Description

In a long document (~300k characters long), typing is very slow, especially near the end of the document.

Taking a performance profile, most of the time is spent in ve.dm.TreeModifier.prototype.getAdjustedPosition.

In my local test on a plain text document of 300k chars, each keystroke at the end spends ~360ms in ve.dm.TransactionProcess.prototype.process.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (9534694b4)mediawiki/extensions/VisualEditormaster+1 -1
TreeModifier: Add optimization for short array comparisonVisualEditor/VisualEditormaster+12 -2
TreeModifier: More optimizationsVisualEditor/VisualEditormaster+19 -6
Update VE core submodule to master (15186ed26)mediawiki/extensions/VisualEditormaster+1 -1
Follow-up Ic1669009: Use for..in loop instead of Object.keys()VisualEditor/VisualEditormaster+8 -14
Update VE core submodule to master (89a8d99f5)mediawiki/extensions/VisualEditormaster+1 -1
getAdjustedPosition: Rewrite inner loop for performanceVisualEditor/VisualEditormaster+31 -7
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Aug 31 2020, 12:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2020, 12:25 PM
Esanders updated the task description. (Show Details)Aug 31 2020, 12:27 PM
Esanders updated the task description. (Show Details)
gerritbot added a comment.Aug 31 2020, 12:45 PM

Change 623355 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] getAdjustedPosition: Rewrite inner loop for performance

https://gerrit.wikimedia.org/r/623355

gerritbot added a project: Patch-For-Review.Aug 31 2020, 12:45 PM
Esanders added a comment.Aug 31 2020, 12:46 PM

After the above patch we spend ~10ms in ve.dm.TransactionProcess.prototype.process.

gerritbot added a comment.Aug 31 2020, 1:23 PM

Change 623355 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] getAdjustedPosition: Rewrite inner loop for performance

https://gerrit.wikimedia.org/r/623355

Maintenance_bot removed a project: Patch-For-Review.Aug 31 2020, 2:10 PM
gerritbot added a comment.Aug 31 2020, 3:54 PM

Change 623387 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Follow-up Ic1669009: Use for..in loop instead of Object.Keys

https://gerrit.wikimedia.org/r/623387

gerritbot added a project: Patch-For-Review.Aug 31 2020, 3:54 PM

Change 623403 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] TreeModifier: More optimizations

https://gerrit.wikimedia.org/r/623403

gerritbot added a comment.Aug 31 2020, 3:54 PM

Change 623410 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] TreeModifier: Add optimization for short array comparison

https://gerrit.wikimedia.org/r/623410

Esanders added a project: Editing-team (Kanban Board).Aug 31 2020, 3:54 PM
Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
Esanders moved this task from To Triage to Triaged on the VisualEditor board.Aug 31 2020, 4:27 PM
gerritbot added a comment.Aug 31 2020, 4:48 PM

Change 623424 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (89a8d99f5)

https://gerrit.wikimedia.org/r/623424

gerritbot added a comment.Aug 31 2020, 5:52 PM

Change 623424 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (89a8d99f5)

https://gerrit.wikimedia.org/r/623424

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Aug 31 2020, 6:00 PM
gerritbot added a comment.Aug 31 2020, 8:11 PM

Change 623387 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Follow-up Ic1669009: Use for..in loop instead of Object.keys()

https://gerrit.wikimedia.org/r/623387

gerritbot added a comment.Sep 1 2020, 9:51 PM

Change 623655 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (15186ed26)

https://gerrit.wikimedia.org/r/623655

gerritbot added a comment.Sep 2 2020, 2:12 AM

Change 623403 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] TreeModifier: More optimizations

https://gerrit.wikimedia.org/r/623403

gerritbot added a comment.Sep 2 2020, 4:07 PM

Change 623655 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (15186ed26)

https://gerrit.wikimedia.org/r/623655

Esanders claimed this task.Sep 2 2020, 4:23 PM
gerritbot added a comment.Sep 2 2020, 7:02 PM

Change 623410 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] TreeModifier: Add optimization for short array comparison

https://gerrit.wikimedia.org/r/623410

gerritbot added a comment.Sep 2 2020, 10:10 PM

Change 623875 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b49db9a5b)

https://gerrit.wikimedia.org/r/623875

gerritbot added a comment.Sep 3 2020, 7:42 PM

Change 623875 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (9534694b4)

https://gerrit.wikimedia.org/r/623875

Esanders moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 10 2020, 7:35 PM
Esanders added a project: Skipped QA.
Esanders removed a project: Patch-For-Review.
• ppelberg closed this task as Resolved.Sep 11 2020, 11:16 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 11 2020, 11:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL