Page MenuHomePhabricator
Create Task
Maniphest T261651

CU 2.0: It isn't always possible to use the tools menu just with keyboard
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

What is the problem?

I cannot tab to the tools menu unless it is visible. Therefore,

  • I cannot tab to the tools menu in the Username column (unless I am hovering over the username cell at the time).
  • If there is another cell highlighted (that doesn't match the current cell), I cannot tab to the menu in the IP column, because the tool menu is only visible when a cell highlights.

Originally from T260217#6402731.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix visibility of the tool menu in Special:Investigate Compare tableTchandersmediawiki/extensions/CheckUsermaster+33 -28
Customize query in gerrit

Related Objects

Event Timeline

dom_walden created this task.Aug 31 2020, 2:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2020, 2:56 PM
dom_walden mentioned this in T260217: Special:Investigate: Allow table cells to be keyboard focusable [4HR].Aug 31 2020, 3:57 PM
• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.Sep 9 2020, 5:04 AM
ARamirez_WMF set the point value for this task to 2.Sep 9 2020, 4:29 PM
ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.
• Niharika triaged this task as Medium priority.Sep 9 2020, 4:43 PM
gerritbot added a comment.Sep 21 2020, 1:59 PM

Change 628805 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] Fix visibility of the tool menu in Special:Investigate Compare table

https://gerrit.wikimedia.org/r/628805

gerritbot added a project: Patch-For-Review.Sep 21 2020, 1:59 PM
Tchanders claimed this task.Sep 21 2020, 2:00 PM
Tchanders moved this task from Cards ready for development to The Letter Song on the Anti-Harassment-Team board.
Tchanders edited projects, added: Anti-Harassment-Team (The Letter Song); removed: Anti-Harassment-Team.
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.
Aklapper added a project: Accessibility.Sep 21 2020, 2:35 PM
dbarratt moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (The Letter Song) board.Sep 22 2020, 3:42 PM
gerritbot added a comment.Sep 22 2020, 4:06 PM

Change 628805 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Fix visibility of the tool menu in Special:Investigate Compare table

https://gerrit.wikimedia.org/r/628805

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2020, 4:10 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 22 2020, 5:00 PM
dom_walden moved this task from QA/Testing 🐞 to Done: Q1 (2020-21) 💯 on the Anti-Harassment-Team (The Letter Song) board.Oct 2 2020, 2:17 PM

I can always tab to the tools menu in both the Username and IP column, regardless of the current state of highlighting.

Test environment: local vagrant CheckUser 2.5 (221a7c6).

• Niharika closed this task as Resolved.Oct 2 2020, 7:28 PM
• Niharika moved this task from Done: Q1 (2020-21) 💯 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment-Team (The Letter Song) board.Oct 2 2020, 7:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits