Page MenuHomePhabricator
Create Task
Maniphest T261662

undo/redo is slow on large documents
Closed, ResolvedPublic
Actions

Description

  1. Open a large doc (>100k)
  2. Hold down a key to type lots of chars quickly (~100).
  3. Press undo

We appear to be trying to render the cursor after each transaction in the undo stack is committed. This should be debounced.

Details

ProjectBranchLines +/-Subject
VisualEditor/VisualEditormaster+4 -1Follow-up I78041b9b4: Debounce just showModelSelection
VisualEditor/VisualEditormaster+2 -1ve.ce.Surface: Debounce onModelDocumentUpdate
mediawiki/extensions/VisualEditormaster+1 -1Update VE core submodule to master (9534694b4)
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Aug 31 2020, 3:54 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptAug 31 2020, 3:54 PM
gerritbot added a comment.Aug 31 2020, 3:54 PM

Change 623411 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] ve.ce.Surface: Debounce onModelDocumentUpdate

https://gerrit.wikimedia.org/r/623411

gerritbot added a project: Patch-For-Review.Aug 31 2020, 3:54 PM
Esanders added a project: Editing-team (FY2021-22 Kanban Board).Aug 31 2020, 3:54 PM
Esanders moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Esanders moved this task from To Triage to Triaged on the VisualEditor board.Aug 31 2020, 4:27 PM
DLynch moved this task from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.Sep 2 2020, 4:22 PM
Esanders claimed this task.Sep 2 2020, 4:23 PM
gerritbot added a comment.Sep 2 2020, 4:24 PM

Change 623411 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ce.Surface: Debounce onModelDocumentUpdate

https://gerrit.wikimedia.org/r/623411

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2020, 5:10 PM
gerritbot added a comment.Sep 2 2020, 10:10 PM

Change 623875 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b49db9a5b)

https://gerrit.wikimedia.org/r/623875

gerritbot added a project: Patch-For-Review.Sep 2 2020, 10:10 PM
gerritbot added a comment.Sep 3 2020, 7:42 PM

Change 623875 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (9534694b4)

https://gerrit.wikimedia.org/r/623875

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 3 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 3 2020, 8:10 PM
Esanders added a project: Skipped QA.Sep 4 2020, 6:15 PM
Esanders moved this task from QA to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.
ppelberg closed this task as Resolved.Sep 5 2020, 12:26 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 5 2020, 12:26 AM
Esanders reopened this task as Open.Sep 23 2020, 8:04 PM

Patch was reverted due to T263607

gerritbot added a comment.Sep 23 2020, 8:23 PM

Change 629471 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Follow-up I78041b9b4: Debounce just showModelSelection

https://gerrit.wikimedia.org/r/629471

gerritbot added a project: Patch-For-Review.Sep 23 2020, 8:23 PM
ppelberg closed this task as Resolved.Sep 25 2020, 2:13 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL