Page MenuHomePhabricator

EditAttemptStep validation error '0' is not of type 'integer'
Closed, ResolvedPublic

Description

While investigating T237063 I noticed that '0' is not of type 'integer' was notably more common in [logstash](https://logstash.wikimedia.org/app/kibana#/dashboard/AWs0a2qSQFnOyvY0scCA?_g=(refreshInterval%3A(display%3AOff%2Cpause%3A!f%2Cvalue%3A0)%2Ctime%3A(from%3Anow-7d%2Cmode%3Aquick%2Cto%3Anow))) than the error that ticket complains of.

Investigation shows that it's the revision_id field being passed as a string sometimes.

Event Timeline

DLynch created this task.Aug 31 2020, 4:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2020, 4:03 PM

Change 623414 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Cast fallback revision_id to a number so it validates

https://gerrit.wikimedia.org/r/623414

Change 623414 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Cast fallback revision_id to a number so it validates

https://gerrit.wikimedia.org/r/623414

ppelberg closed this task as Resolved.Sep 1 2020, 1:41 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 1 2020, 1:41 AM