Page MenuHomePhabricator
Create Task
Maniphest T261699

[M] Media Search: Ability to copy the file name and Wikitext snippet in the quick view
Closed, ResolvedPublic
Actions

Description

Currently if you are on Commons and you want to quickly copy a filename or the corresponding Wikitext snippet to speed up your editing process on Wikipedia you would need to go to the file page.

Two parts to address this:

  1. Add a new line to the quick view that includes the Wikitext "snippet"
  2. Add a "Copy" action to both the new Wikitext line and the filename line that copies them to your clipboard

Screen Shot 2020-08-31 at 3.19.00 PM.png (1×1 px, 1 MB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Get CopyTextLayout working in earlier iOS versionsmediawiki/extensions/WikibaseMediaInfomaster+22 -5
Add copyable filename to QuickView and CopyTextLayout componentmediawiki/extensions/WikibaseMediaInfomaster+279 -28
Customize query in gerrit

Related Objects

Event Timeline

mwilliams created this task.Aug 31 2020, 9:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2020, 9:20 PM
CBogen added a project: MediaSearch (MediaSearch-ReleaseCandidate).Sep 8 2020, 4:14 PM
mwilliams moved this task from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.Sep 16 2020, 8:47 PM
CBogen renamed this task from Media Search: Ability to copy the file name and Wikitext snippet in the quick view to [M] Media Search: Ability to copy the file name and Wikitext snippet in the quick view.Sep 23 2020, 4:42 PM
CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.
mwilliams updated the task description. (Show Details)Sep 23 2020, 4:44 PM
mwilliams updated the task description. (Show Details)
CBogen mentioned this in T263663: [S] Instrument file name and wikitext snippet copy in MediaSearch quickview.Sep 23 2020, 5:06 PM
• AnneT claimed this task.Sep 28 2020, 6:35 PM
• AnneT added a comment.Sep 28 2020, 10:04 PM

@mwilliams I've been looking into this and wanted to run a couple of things by you:

  1. Do you want a different icon for the filename depending on the media type?
  2. We can do this now for the filename, but for the snippet it probably makes the most sense to wait and see if this RFC goes through and we can get search goodies like the snippet, word count, etc. for free.
mwilliams added a comment.EditedSep 28 2020, 10:20 PM

@AnneT Good idea, having different icons depending on the media type sounds ideal.

We could do something like this:

icon.jpg (176×640 px, 30 KB)

But also, the more I thought about the current icon (and these new ones) the more I questioned if these really signify "File name"? We initially copied these icons from the media viewer but it seems like audio and video file types never show up in the media viewer.

Going to think on that a bit more but if switching to those new ones is easy, maybe we start there?

• AnneT added a comment.Sep 28 2020, 10:22 PM

Thanks! That sounds good; they're easy to swap out so we can change them up down the road.

• AnneT moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.Sep 29 2020, 12:21 AM
gerritbot added a comment.Sep 29 2020, 9:39 PM

Change 630957 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Add copyable filename to QuickView and CopyTextLayout component

https://gerrit.wikimedia.org/r/630957

gerritbot added a project: Patch-For-Review.Sep 29 2020, 9:39 PM
• AnneT moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Sep 29 2020, 9:41 PM
gerritbot added a comment.Oct 29 2020, 7:42 PM

Change 630957 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Add copyable filename to QuickView and CopyTextLayout component

https://gerrit.wikimedia.org/r/630957

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 29 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 29 2020, 8:10 PM
• AnneT moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 31 2020, 12:37 AM
• Ramsey-WMF moved this task from Needs QA to Doing on the Structured-Data-Backlog (Current Work) board.Nov 9 2020, 7:32 PM
• Ramsey-WMF subscribed.

This hit production before it went all the way through QA. It woks beautifully on Windows desktop, but fails on mobile (tested on iPhone Safari and Chrome). 😦

CBogen subscribed.Nov 9 2020, 7:38 PM

@Ramsey-WMF I tested on iPhone Safari (and Mac OS desktop) and it worked fine. Could it be a Safari version?

• Ramsey-WMF added a comment.Nov 9 2020, 7:49 PM

I tested further on other devices I have and it seems it depends on iOS version. If you're on v. 14 it works! Older iOS versions (11, 12, and some variants of 13) do not work.

• AnneT moved this task from Doing to Ready for Development on the Structured-Data-Backlog (Current Work) board.Dec 16 2020, 4:25 PM
gerritbot added a comment.Jan 15 2021, 9:14 PM

Change 656511 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Get CopyTextLayout working in earlier iOS versions

https://gerrit.wikimedia.org/r/656511

gerritbot added a project: Patch-For-Review.Jan 15 2021, 9:14 PM
• AnneT moved this task from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.Jan 15 2021, 9:37 PM
gerritbot added a comment.Feb 1 2021, 8:23 PM

Change 656511 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Get CopyTextLayout working in earlier iOS versions

https://gerrit.wikimedia.org/r/656511

• AnneT moved this task from Code Review to Verify on Production on the Structured-Data-Backlog (Current Work) board.Feb 1 2021, 8:43 PM
• AnneT moved this task from Verify on Production to Needs QA on the Structured-Data-Backlog (Current Work) board.
egardner moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Feb 1 2021, 9:00 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.29; 2021-02-02); removed MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Feb 1 2021, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 1 2021, 9:10 PM
Etonkovidova closed this task as Resolved.Feb 12 2021, 2:09 AM
Etonkovidova subscribed.

Checked in commons wmf.30 with additional testing on Safari 11 and iPhone. All seem to be as expected.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits