Remove or simplify unused static/index.html files
Open, LowPublic
Actions

Assigned To

Authored By

	• bearND
	Aug 31 2020, 11:13 PM

Description

Several Node.js services based on service-template-node[1] include a static/index.html file with old HTML, which keeps showing up when doing skin or JS related migrations/deprecations[2]. These likely don't render well currently and also may no longer match current MW output behavior. These are usually not served to clients behind RESTBase and serve no purpose besides demonstrating how to serve a static file.

This task is to either simplify the HTML or remove the file.
If we remove the file we should consider to also disable serving of static files in app.js[3].

List of repos with this file[2]:

[1] https://github.com/wikimedia/service-template-node
[2] https://codesearch.wmcloud.org/search/?q=ResourceLoaderDynamicStyles&i=nope&files=html%24&repos=
[3] https://github.com/wikimedia/service-template-node/blob/master/app.js#L236

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Removed unused static/index.html files	mediawiki/services/mobileapps	master	+0 -668

Customize query in gerrit

Event Timeline

• bearND created this task.Aug 31 2020, 11:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2020, 11:13 PM

• bearND added a project: good first task.Sep 1 2020, 3:03 AM

• bearND updated the task description. (Show Details)

daniel triaged this task as Low priority.Sep 1 2020, 8:11 PM

daniel moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.

LGoto moved this task from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog-Deprecated board.Sep 2 2020, 3:43 PM

Krinkle awarded a token.Sep 2 2020, 3:56 PM

Krinkle unsubscribed.Sep 2 2020, 6:03 PM

Assuming this task is about the [Deprecated] service-template-node code project, hence adding that project tag so other people who don't know or don't care about team tags can find this task when searching via projects. Please set appropriate project tags when possible. Thanks!

Hello
i want to work on this task.
i understand that i have to delete html file from repo and and disable serving of html file form node js server.
But i dont understand what is the use of list of repo given.
Can any body provide me hint what's that.
And please tell me that if i am thinking in right direction to solve the issue.

So i can start solving this issue.

Thank you

But i dont understand what is the use of list of repo given.

If you refer to the (currently) five checkboxes in the task description, then these were the code repos at the time of creating this ticket which all need(ed) each a separate fix.

i have solved this issue please check it out @bearND

https://github.com/wikimedia/service-template-node/pull/144

Hi @Bharatkhatri351, no need to ping anyone before a patch has passed all CI checks. :) Also, why is a change in the service-template-node repo proposed, which is not listed under List of repos with this file in the task description here?

@Bharatkhatri351: ping - could you answer my question? Thanks :)

sorry @Aklapper i was busy in another project so not able to reply.
Actually at first i didn't understand why list of repo was given. actually i was thinking i have to do changes in service-template-node and i was thinking wrong. And its my first project in which i am using github so thats why i mentioned link and ping authored because i didn't know how this github stuff work.

i will fix this issue later.because i am working on another project. and if someone another intersted in issue can fix this i am not assigning this issue

Thank You.

Change 674925 had a related patch set uploaded (by Sahilgrewalhere; author: Sahilgrewalhere):
[mediawiki/services/mobileapps@master] Removed unused static/index.html files

https://gerrit.wikimedia.org/r/674925

gerritbot added a project: Patch-For-Review.Mar 25 2021, 4:11 PM

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 1 2023, 4:22 PM

Change 674925 merged by jenkins-bot:

[mediawiki/services/mobileapps@master] Removed unused static/index.html files

https://gerrit.wikimedia.org/r/674925

Jgiannelos updated the task description. (Show Details)Jun 13 2023, 2:52 PM

Pppery removed a project: Patch-Needs-Improvement.Jun 23 2023, 3:44 PM

EbenezerRao claimed this task.Sep 2 2025, 11:04 AM