Page MenuHomePhabricator

Remove or simplify unused static/index.html files
Open, LowPublic

Description

Several Node.js services based on service-template-node[1] include a static/index.html file with old HTML, which keeps showing up when doing skin or JS related migrations/deprecations[2]. These likely don't render well currently and also may no longer match current MW output behavior. These are usually not served to clients behind RESTBase and serve no purpose besides demonstrating how to serve a static file.

This task is to either simplify the HTML or remove the file.
If we remove the file we should consider to also disable serving of static files in app.js[3].

List of repos with this file[2]:

  • mobileapps
  • wikifeeds
  • recommendation-api
  • trending-edits
  • graphoid

[1] https://github.com/wikimedia/service-template-node
[2] https://codesearch.wmcloud.org/search/?q=ResourceLoaderDynamicStyles&i=nope&files=html%24&repos=
[3] https://github.com/wikimedia/service-template-node/blob/master/app.js#L236

Event Timeline

bearND created this task.Aug 31 2020, 11:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2020, 11:13 PM
bearND updated the task description. (Show Details)
daniel triaged this task as Low priority.Sep 1 2020, 8:11 PM
daniel moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.
Krinkle removed a subscriber: Krinkle.Sep 2 2020, 6:03 PM

Assuming this task is about the service-template-node code project, hence adding that project tag so other people who don't know or don't care about team tags can find this task when searching via projects. Please set appropriate project tags when possible. Thanks!