Page MenuHomePhabricator

More minor bugs introduced with campaign fallback
Open, Needs TriagePublic

Description

Here are the issues:

  1. bannersNotGuaranteedToDisplay not reset on new iteration of fallback loop.
  2. If two campaigns use the same identifier for the impressionDiet feature, and they both target the same users at the same time, a single pageview may be counted twice in impression tallies. Other impressionDiet issues may be present in that scenario; full investigation pending.
  3. If more than one campaign targeting a given user segment is throttled, the percentage of pageviews selected may be greater than the percentage requested in throttling settings.
  4. bannersCount property in campaignStatuses is just the number of banners associated with the campaign. This is not a relevant data point; maybe the legacy banner_count (for counting impressions?) was intended?
  5. If multiple campaigns have enabled banner history and target the same user segment at the same time, and the banner history configuration settings (like sample rate) for the campaigns are not the same, the results may be unpredictable. Banner history lacks a reconciliation mechanism for different settings in this scenario.

Event Timeline

AndyRussG created this task.Sep 1 2020, 5:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2020, 5:22 AM
AndyRussG updated the task description. (Show Details)Sep 1 2020, 6:09 AM

Change 623314 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] Campaign fallback follow-up: refactor data handling and some methods

https://gerrit.wikimedia.org/r/623314

The attached patch addresses only the first issue in the description (bannersNotGuaranteedToDisplay not reset on new iteration of fallback loop).

AndyRussG updated the task description. (Show Details)Sep 1 2020, 8:18 AM

Change 623314 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Campaign fallback follow-up: refactor data handling and some methods

https://gerrit.wikimedia.org/r/623314

AndyRussG updated the task description. (Show Details)Sep 14 2020, 9:15 PM