Page MenuHomePhabricator

MediaSearch: QuickView display with empty search
Closed, DuplicatePublic

Description

Note: Should a file in QuickView be dismissed when it doesn't fit the search criteria selected from the filters?

  1. On Special:MediaSearch perform any search for images (make sure that it fetches some results).
  2. Click on any of the images in result set to bring up QuickView.
  3. Select option(s) from the Image size/File type filters so there won't be any results returned.

The page would still display the file in QuickView and "We didn't find any results" message is pushed toward the bottom of the page.

Screen Shot 2020-09-01 at 3.08.06 PM.png (722×1 px, 261 KB)
Screen Shot 2020-09-01 at 3.09.11 PM.png (723×1 px, 97 KB)

Note:
(1) Keep a file in QuickView with "We didn't find any results" message looks confusing - does the file in QuickView fits the selected search criteria?
(2) There might be an edge case when the file in Quickview is the only result of the query (no real life example so far), e.g.

  • a user performs a search for all image sizes and all file types
  • selects one image to view in QuickView
  • selects options in Image size/File types filters and the file in QuickView is the only one that fits the selected criteria. How to inform a user that the file in QuickView is the only one?

Event Timeline

@Etonkovidova I believe this is a duplicate of T261818 - if you think there is some difference, please reopen. Thanks!

@Etonkovidova I believe this is a duplicate of T261818 - if you think there is some difference, please reopen. Thanks!

T261818 sufficiently describes the issue and the solution proposed there would solve it.