Page MenuHomePhabricator
Create Task
Maniphest T261810

Striker not compatible with mwoauth>=0.3.5
Closed, ResolvedPublic
Actions

Description

https://github.com/mediawiki-utilities/python-mwoauth/commit/7f1da20c158bd4392b7b16a2c6ae783de76ef2ff landed in 0.3.5 and includes its own handling for the byte string problem that Striker worked around in https://github.com/wikimedia/labs-striker/commit/b2cb095316d8772ef909891e8159d46f85fbeaa1

Details

SubjectRepoBranchLines +/-
2020-09-02 releaselabs/striker/deploymaster+84 -51
OAuth: Use byte to string conversion from mwoauth>=0.3.5labs/strikermaster+6 -22
Customize query in gerrit

Related Objects

Event Timeline

bd808 created this task.Sep 1 2020, 11:45 PM
Restricted Application added a project: User-bd808. · View Herald TranscriptSep 1 2020, 11:45 PM
bd808 triaged this task as High priority.Sep 1 2020, 11:45 PM

This is blocking the next deployment

gerritbot added a comment.Sep 2 2020, 12:21 AM

Change 623667 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[labs/striker@master] OAuth: Use byte to string conversion from mwoauth>=0.3.5

https://gerrit.wikimedia.org/r/623667

gerritbot added a project: Patch-For-Review.Sep 2 2020, 12:21 AM
gerritbot added a comment.Sep 2 2020, 4:22 PM

Change 623667 merged by jenkins-bot:
[labs/striker@master] OAuth: Use byte to string conversion from mwoauth>=0.3.5

https://gerrit.wikimedia.org/r/623667

gerritbot added a comment.Sep 2 2020, 4:39 PM

Change 623075 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[labs/striker/deploy@master] Bump striker and wheels sub modules

https://gerrit.wikimedia.org/r/623075

gerritbot added a comment.Sep 2 2020, 7:52 PM

Change 623075 merged by jenkins-bot:
[labs/striker/deploy@master] 2020-09-02 release

https://gerrit.wikimedia.org/r/623075

Stashbot mentioned this in T144111: Allow self-service creation of Maniphest projects for Tools.Sep 2 2020, 9:46 PM
Stashbot mentioned this in T198114: Allow tool maintainers to delete toolinfo via ToolsAdmin.
Stashbot mentioned this in T223610: Tool creation and toolinfo create/edit forms are the same causing confusion about field mutability/use.
Stashbot mentioned this in T245804: Reassign base URLs for toolinfo records' web service links.

Mentioned in SAL (#wikimedia-operations) [2020-09-02T21:46:25Z] <bd808@deploy1001> Started deploy [striker/deploy@3c2090a]: Deploying r20200902 tag (T198114, T223610, T245804, T144111, T261810)

Stashbot added a comment.Sep 2 2020, 9:48 PM

Mentioned in SAL (#wikimedia-operations) [2020-09-02T21:47:59Z] <bd808@deploy1001> Finished deploy [striker/deploy@3c2090a]: Deploying r20200902 tag (T198114, T223610, T245804, T144111, T261810) (duration: 01m 34s)

bd808 closed this task as Resolved.Sep 2 2020, 10:14 PM
Nintendofan885 removed a project: Patch-For-Review.Sep 13 2020, 3:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL