Page MenuHomePhabricator

Refactor module loading in FullEntityParserOutputGenerator to FP-POG
Closed, ResolvedPublic3 Estimated Story Points

Description

There is currently some js module loaded in FullEntityParserOutputGenerator

		if ( $this->repoSettings->getSetting( 'federatedPropertiesEnabled' ) ) {
			$parserOutput->setEnableOOUI( true );
			$parserOutput->addModules( 'wikibase.federatedPropertiesLeavingSiteNotice' );
		}

That could move to the POG loaded if FP is enabled (FederatedPropertiesEntityParserOutputGenerator). This allows the whole setting parameter to the constructor to be removed probably.

Event Timeline

Change 624594 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Refactor module loading in FullEntityParserOutputGenerator to FederatedPropertiesEntityParserOutputGenerator

https://gerrit.wikimedia.org/r/624594

Change 624594 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Refactor module loading

https://gerrit.wikimedia.org/r/624594