Refactor module loading in FullEntityParserOutputGenerator to FP-POG
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	• toan
	Sep 2 2020, 1:09 PM

Description

There is currently some js module loaded in FullEntityParserOutputGenerator

		if ( $this->repoSettings->getSetting( 'federatedPropertiesEnabled' ) ) {
			$parserOutput->setEnableOOUI( true );
			$parserOutput->addModules( 'wikibase.federatedPropertiesLeavingSiteNotice' );
		}

That could move to the POG loaded if FP is enabled (FederatedPropertiesEntityParserOutputGenerator). This allows the whole setting parameter to the constructor to be removed probably.

Details

	Subject	Repo	Branch	Lines +/-
	FP: Refactor module loading	mediawiki/extensions/Wikibase	master	+2 -9

Customize query in gerrit

Event Timeline

• toan created this task.Sep 2 2020, 1:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2020, 1:09 PM

Addshore moved this task from Backlog to Ready to estimate on the Wikibase - Federated Properties board.Sep 3 2020, 8:52 AM

Addshore awarded a token.Sep 3 2020, 8:59 AM

Addshore set the point value for this task to 3.

Addshore edited projects, added Wikibase - Federated Properties (Sprint 6/6 (Hike 2)); removed Wikibase - Federated Properties.

Addshore updated the task description. (Show Details)

Addshore triaged this task as Medium priority.Sep 3 2020, 9:08 AM

Rosalie_WMDE claimed this task.Sep 3 2020, 11:32 AM

Rosalie_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 6/6 (Hike 2)) board.

Change 624594 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Refactor module loading in FullEntityParserOutputGenerator to FederatedPropertiesEntityParserOutputGenerator

https://gerrit.wikimedia.org/r/624594

gerritbot added a project: Patch-For-Review.Sep 4 2020, 8:11 AM

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 6/6 (Hike 2)) board.Sep 4 2020, 8:41 AM

Change 624594 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Refactor module loading

https://gerrit.wikimedia.org/r/624594

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 4 2020, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2020, 5:10 PM

Rosalie_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Sprint 6/6 (Hike 2)) board.Sep 5 2020, 9:04 PM

Addshore closed this task as Resolved.Oct 30 2020, 5:49 PM