Page MenuHomePhabricator
Create Task
Maniphest T261877

Warnings / errors should not be shown in the ui on the demo systems
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

We need to make this conditional in the ansible setup

https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/build/federated-properties/templates/LocalSettings.php.j2#L5-L10

These verbose details should be visible in the test system but NOT in the demo systems

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+2 -0FP: set display_errors 0 on demo system
mediawiki/extensions/Wikibasemaster+12 -6FP: Dont show dev errors on demo system
Customize query in gerrit

Event Timeline

toan created this task.Sep 2 2020, 3:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2020, 3:44 PM
Addshore moved this task from Backlog to Ready to estimate on the Wikibase - Federated Properties board.Sep 3 2020, 8:52 AM
Addshore updated the task description. (Show Details)Sep 3 2020, 8:58 AM
Addshore set the point value for this task to 3.
Addshore changed the point value for this task from 3 to 2.
Addshore edited projects, added Wikibase - Federated Properties (Sprint 6/6 (Hike 2)); removed Wikibase - Federated Properties.
Addshore triaged this task as Medium priority.Sep 3 2020, 9:07 AM
toan claimed this task.Sep 4 2020, 9:25 AM
toan moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 6/6 (Hike 2)) board.
gerritbot added a comment.Sep 4 2020, 9:43 AM

Change 624630 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: Dont show dev errors on demo system

https://gerrit.wikimedia.org/r/624630

gerritbot added a project: Patch-For-Review.Sep 4 2020, 9:43 AM
toan moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 6/6 (Hike 2)) board.Sep 4 2020, 10:52 AM
gerritbot added a comment.Sep 7 2020, 9:13 AM

Change 624630 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Dont show dev errors on demo system

https://gerrit.wikimedia.org/r/624630

toan moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Sprint 6/6 (Hike 2)) board.Sep 7 2020, 9:54 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 7 2020, 10:00 AM
gerritbot added a comment.Sep 7 2020, 10:16 AM

Change 625617 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: set display_errors 0 on demo system

https://gerrit.wikimedia.org/r/625617

toan moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 6/6 (Hike 2)) board.Sep 7 2020, 10:25 AM
gerritbot added a comment.Sep 7 2020, 3:02 PM

Change 625617 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: set display_errors 0 on demo system

https://gerrit.wikimedia.org/r/625617

Addshore closed this task as Resolved.Oct 30 2020, 5:49 PM
Addshore added a subscriber: Addshore.

I believe this is all done

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2020, 6:11 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL