Page MenuHomePhabricator

Use a BlobStore for storing var dumps
Closed, ResolvedPublic

Description

The mechanism used to store var dumps was copied in ancient times from the Revision class, mimicking the code used to store page contents. This is brittle and hacky. That code path should be migrated to use BlobStore.

Note, this is currently blocked on cleaning up that code area, which in turn means removing BC code in 1.36 or 1.37, following T213006.

Event Timeline

Change 538599 had a related patch set uploaded (by Daimona Eaytoy; owner: Daniel Kinzler):
[mediawiki/extensions/AbuseFilter@master] Use a BlobStore for storing var dumps.

https://gerrit.wikimedia.org/r/538599

daniel subscribed.

Adding to the PET external code review board. This removes blockers for MCR cleanup, specifically T198341 and T183490.

daniel triaged this task as Medium priority.Sep 6 2020, 8:02 PM

@daniel Might I ping you for review once the patch is ready?

@daniel Might I ping you for review once the patch is ready?

sure

Change 538599 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Use a BlobStore for storing var dumps

https://gerrit.wikimedia.org/r/538599

Daimona claimed this task.