Links in books throw errors on mobile (Uncaught ReferenceError: coll_clear_collection is not defined / Uncaught ReferenceError: coll_create_chapter is not defined)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Sep 2 2020, 7:45 PM

Description

On mobile it appears to be possible to reveal links which are hidden by default via user scripts however when clicked these throw errors https://he.m.wikipedia.org/wiki/%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%A1%D7%A4%D7%A8
It seems from the production logs at least one user is doing something along these lines.

I could replicate by the following:
In JS console run:

$('#collectionListContainer a').attr('style','')

Click "create chapter"
Uncaught ReferenceError: coll_create_chapter is not defined

Either this page should be blanked on mobile, or all the load should be loaded, warts and all.

	Subject	Repo	Branch	Lines +/-
	Replace fragile <a onclick="…"> triggers	mediawiki/extensions/Collection	master	+13 -3

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2020, 7:45 PM

Change 960563 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Collection@master] Add safe-guards to fragile <a onclick="…"> triggers

Change 960563 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Replace fragile <a onclick="…"> triggers

Jdlrobson closed this task as Resolved.Oct 17 2023, 8:56 PM

Jdlrobson claimed this task.