| MusikAnimal | |
| Sep 2 2020, 9:02 PM |
| F32270224: Screen Shot 2020-09-11 at 9.49.21 AM.png | |
| Sep 11 2020, 1:57 PM |
| F32270223: Screen Shot 2020-09-11 at 9.49.08 AM.png | |
| Sep 11 2020, 1:57 PM |
This was noticed in the mobile view, but may be reproducible under some conditions in desktop as well.
Steps to reproduce:
Acceptance criteria:
Change 623866 had a related patch set uploaded (by MusikAnimal; owner: MusikAnimal):
[mediawiki/core@master] Don't close .mw-notification when clicking on <select> element
Change 623866 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.notification: Don't close notif when clicking <select> element
You can now select an expiry option from the dropdown on mobile.
After making a selection from the dropdown, the popup remains visible for about 6 seconds.
However, I find that if I open the dropdown for a second time, the popup dismisses after 6 seconds even if the dropdown is open. So, you can make a second (or even third) expiry selection (if you change your mind), but you have to be quick. I might raise this as a separate bug.
Similarly to described in T261476#6440072, while the dropdown is open if I tap outside the dropdown (dismissing the dropdown) the popup remains indefinitely.
Devices and browsers tested (on browserstack):
Test environment: https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (e81e81e) 2020-09-06T18:54:00.
Change 626532 had a related patch set uploaded (by Dmaza; owner: MusikAnimal):
[mediawiki/core@REL1_35] mediawiki.notification: Don't close notif when clicking <select> element
Change 626532 merged by jenkins-bot:
[mediawiki/core@REL1_35] mediawiki.notification: Don't close notif when clicking <select> element
I have tested this, and I can now make a selection of a temporary time period in mobile (see screenshot example below). The star is half-shaded (see screenshot example below), but only upon refresh (which will be separately handled in T261970). As for the issue Dom described (the pop-up not remaining open until selection period complete, when multiple selections are made) can be handled in a separate ticket (T262672). I'm marking this as Done.
Selecting from dropdown:
