Page MenuHomePhabricator
Create Task
Maniphest T261972

Japan banner emojis
Closed, ResolvedPublic
Actions

Description

Hi John,

Could you give this banner a quick look? It has several emojis in the main content--they'll display differently across browsers but (hopefully) should be pretty straightforward!

Would be great to put this up asap.

Thanks!

Related Objects
Search...

Event Timeline

• TSkaff created this task.Sep 3 2020, 5:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2020, 5:04 PM
spatton triaged this task as High priority.Sep 3 2020, 5:41 PM
• jbolorinos-ctr added a comment.Sep 3 2020, 5:44 PM

Ok will get started on this right now, thanks Thea!

• jbolorinos-ctr closed subtask T261975: Colorless emojis on IE 11 and on some versions of Chrome as Resolved.Sep 4 2020, 7:28 PM
• jbolorinos-ctr added a comment.Sep 8 2020, 5:49 PM

Screenshot Test Results - Desktop:

• TSkaff added subscribers: spatton, Pcoombe.Sep 8 2020, 9:12 PM

Hi all, sounds like with Sam's fix, this is good to go or am I missing something? @jbolorinos-ctr @spatton @Pcoombe

Pcoombe added a comment.Sep 9 2020, 12:53 PM

Yes @TSkaff I think these are good to go. There's still T261976: Missing frb-greeting emoji on Mac OS 10.10 and Windows 8.1 and some older mobile devices but that's only on a few older systems and I don't think the missing emojis disrupt the message too much

• jbolorinos-ctr added a comment.Sep 9 2020, 11:14 PM

This banner is ready to test (pass with issues)

I dont think it will interrupt the flow at all missing the emoji from the greeting (as reported in T261972), and as Peter pointed out it's on less used systems.

Thanks for double checking on this @TSkaff

• jbolorinos-ctr closed this task as Resolved.Sep 9 2020, 11:17 PM
• jbolorinos-ctr closed subtask T261974: Emoji appears by itself on a newline as Declined.Dec 10 2020, 5:09 PM
• jbolorinos-ctr closed subtask T261976: Missing frb-greeting emoji on Mac OS 10.10 and Windows 8.1 and some older mobile devices as Declined.Dec 10 2020, 5:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL