Page MenuHomePhabricator

Uncaught TypeError: Cannot read property 'metaKey' of undefined / TypeError: event is undefined
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

MediaWiki version: n/a
https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.09.03/clienterror/?id=AXRTkqhEMQ_08tQafzOd

message
Uncaught TypeError: Cannot read property 'metaKey' of undefined

The same code path also triggers " TypeError: event is undefined".

Impact

Notes

Details

Request ID
undefined
Request URL
https://ca.wikipedia.org/wiki/Ven%C3%A8rca
Stack Trace
exception.trace
 	at ULS.onSelect  <url>:138:621
at ULS.select  <url2>:61:507
at LanguageFilter.keypress  <url2>:78:130
at HTMLInputElement.dispatch  <url>:224:742
at HTMLInputElement.elemData.handle  <url>:221:388
exception.trace
at onSelect <url2>:134:614
at select <url>:61:507
at keypress <url>:78:130
at dispatch <url2>:220:742
at add/elemData.handle <url2>:217:388

Event Timeline

Jdlrobson renamed this task from Uncaught TypeError: Cannot read property 'metaKey' of undefined to Uncaught TypeError: Cannot read property 'metaKey' of undefined / TypeError: event is undefined.Sep 3 2020, 6:57 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson edited Stack Trace. (Show Details)
Nikerabbit triaged this task as Medium priority.Sep 28 2020, 2:35 PM
Nikerabbit subscribed.

If I remember correctly, there is one code path in jquery.uls that does not pass the event properly.

Change 635671 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/UniversalLanguageSelector@master] event may be undefined

https://gerrit.wikimedia.org/r/635671

Change 635671 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls

https://gerrit.wikimedia.org/r/635671

Amire80 reassigned this task from Amire80 to Jdlrobson.
Amire80 subscribed.

Assuming it was fixed by the patch.

Not seeing this bug in the last 7 days so looks good! Thanks!