Page MenuHomePhabricator

Uncaught TypeError: Cannot read property 'offsetHeight' of null
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

MediaWiki version: n/a

message
Uncaught TypeError: Cannot read property 'offsetHeight' of null

Impact

This seems to be about positioning something. It does not seem to prevent publishing. Seems to be a good candidate to use try-catch to downgrade to a warning or just ignore.

Notes

Details

Request ID
undefined
Request URL
https://he.wikipedia.org/w/index.php?title=%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%AA%D7%A8%D7%92%D7%95%D7%9D_%D7%AA%D7%95%D7%9B%D7%9F&page=%D0%91%D0%BE%D0%BA%D1%81%D0%B8%D1%82%D0%BE%D0%B3%D0%BE%D1%80%D1%81%D0%BA%D0%B8%D0%B9+%D1%80%D0%B0%D0%B9%D0%BE%D0%BD&from=ru&to=he&targettitle=&campaign=interlanguagelink
Stack Trace
exception.trace
at VeCeLinearSelection.ve.ce.LinearSelection.getNodeClientRectFromRange  https://he.wikipedia.org/w/load.php?lang=he&modules=ext.visualEditor.base%2Ccore%2Cdiffing%2Cmediawiki%2Cmwcore%2Cmwlink%2Cmwmeta%2Csanitize%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils&skin=vector&version=jctly:529:550
at VeCeLinearSelection.ve.ce.LinearSelection.getSelectionBoundingRect  https://he.wikipedia.org/w/load.php?lang=he&modules=ext.visualEditor.base%2Ccore%2Cdiffing%2Cmediawiki%2Cmwcore%2Cmwlink%2Cmwmeta%2Csanitize%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils&skin=vector&version=jctly:528:639
at VeCeLinearSelection.ve.ce.Selection.getSelectionFocusRect  https://he.wikipedia.org/w/load.php?lang=he&modules=ext.visualEditor.base%2Ccore%2Cdiffing%2Cmediawiki%2Cmwcore%2Cmwlink%2Cmwmeta%2Csanitize%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils&skin=vector&version=jctly:439:681
at VeCeLinearSelection.ve.ce.LinearSelection.getSelectionFocusRect  https://he.wikipedia.org/w/load.php?lang=he&modules=ext.visualEditor.base%2Ccore%2Cdiffing%2Cmediawiki%2Cmwcore%2Cmwlink%2Cmwmeta%2Csanitize%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils&skin=vector&version=jctly:530:495
at VeUiCXSurface.ve.ui.Surface.scrollSelectionIntoView  https://he.wikipedia.org/w/load.php?lang=he&modules=ext.visualEditor.base%2Ccore%2Cdiffing%2Cmediawiki%2Cmwcore%2Cmwlink%2Cmwmeta%2Csanitize%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils&skin=vector&version=jctly:610:635
at later  https://he.wikipedia.org/w/load.php?lang=he&modules=diffMatchPatch%2Cdompurify%2Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cpapaparse%2Crangefix%2Cspark-md5%2CtreeDiffer%2Cunicodejs%7Cext.cx.model%2Cutil%7Cext.cx.widgets.spinner%7Cext.cx.wikibase.link%7Cjquery.tablesorter%2Cui%7Cjquery.tablesorter.styles%7Cmediawiki.action.view.redirectPage%7Cmediawiki.deflate%2Cpulsatingdot%7Cmediawiki.interface.helpers.styles%7Cmediawiki.language.months%7Cmediawiki.skinning.content.parsoid%7Cmediawiki.widgets.styles%7Cmw.cx.MachineTranslation%2CMwApiRequestManager%2CSiteMapper%2Cdm%2Cinit%2Cui%2Cutil%7Cmw.cx.dm.PageTitleModel%2CTranslation%2CTranslationIssue%2CWikiPage%7Cmw.cx.init.Translation%7Cmw.cx.tools.IssueTrackingTool%2CTranslationTool%2CTranslationToolFactory%7Cmw.cx.ui.Categories%2CCategoryMultiselectWidget%2CHeader%2CInfobar%2CMessageWidget%2CPageTitleWidget%2CPersonalMenuWidget%2CTranslationToolWidget%2CTranslationView%7Coojs-ui.styles.icons-user%2Cicons-wikimedia%7Cve.ce.CXLintableNode%7Cve.dm.CXLintableNode%7Cve.init.mw.CXTarget%7Cve.ui.CXDesktopContext%2CCXSurface&skin=vector&version=1n70e:217:240

Event Timeline

Nikerabbit updated the task description. (Show Details)

Now being filtered from the logstash board by default as logspam.

Change 676910 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Add extra check for annotation node height

https://gerrit.wikimedia.org/r/676910

The above patch suppresses the error in VE. If the error only originates in CX, it might worth seeing why that is, but I am unable to reproduce it so far.

Change 676910 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Add extra check for annotation node height

https://gerrit.wikimedia.org/r/676910

Change 677670 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (83f89605d)

https://gerrit.wikimedia.org/r/677670

Change 677670 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (83f89605d)

https://gerrit.wikimedia.org/r/677670

matmarex edited projects, added Skipped QA; removed Patch-For-Review.

(check logs after it's deployed)

Errors have almost completely disappeared after 15 April, when this patch was deployed (train was delayed that week: T278345#7006973). Searching for "Cannot read property 'offsetHeight' of null":

logstash.wikimedia.org_app_discover.png (550×2 px, 82 KB)

The few remaining results seem to occur either in user scripts, or on Special:MediaSearch, so these are different issues.