Page MenuHomePhabricator

Review holders of commit rights in WMF deployed extensions
Closed, InvalidPublic

Description

This came out of a few conversations. Will assign to Sumana when she creates an account here :)

Details

Reference
fl430

Event Timeline

flimport raised the priority of this task from to Medium.Sep 12 2014, 1:40 AM
flimport set Reference to fl430.

aklapper wrote on 2014-07-02 20:21:32 (UTC)

greg: Isn't this Diffusion/Differential territory (which we won't have for day 1)? Or what do I miss? :)

greg wrote on 2014-07-02 20:33:31 (UTC)

Good point.

qgil wrote on 2014-07-07 14:41:28 (UTC)

In fact Sumana stepped down as controller of the Gerrit project ownership process. We need to figure out how this process should work, hopefully before "Differential Day 1". In the maintain, I bet Chad is a good contact.

Qgil lowered the priority of this task from Medium to Low.Oct 9 2014, 11:13 PM
greg lowered the priority of this task from Low to Lowest.Sep 9 2015, 3:17 PM

The point of this task was to use the "moment in time" during the migration to review +2 holders. My point of view: If it is important to do a review of who has +2 then it shouldn't matter if we're migrating or not, just do it whenever.

I see this as unneeded now or very low priority (and not a blocker). Leaving here for now if someone feels inspired.

I wonder what is the right project for this task to live in? thoughts @Qgil? It should at least be in the gerrit-migration one plus something else (where do other things related to +2 live?).

Qgil added a comment.Sep 9 2015, 5:03 PM

You created this task, so I guess you know where it comes from. :) My first question would be: do we have an actual problem with the current holders of commit rights? I'm not hearing about anybody abusing the system or exercising these rights wrongly, but maybe I'm just not listening in the right places (honestly!).

Krenair added a subscriber: Krenair.Sep 9 2015, 5:08 PM

I have a problem with ldap/wmf implicitly granting +2 rights in various places that it should not (there's a separate task for this). Hopefully that won't be possible with Differential though, and people who suddenly find themselves without +2 rights due to no more ldap-based ACLs will have to formally request them the proper way.

In T262#1621351, @Qgil wrote:

You created this task, so I guess you know where it comes from. :)

'twas a meeting that @RobLa-WMF, myself, and Summana were in, but I forget the bigger context of that meeting. :)

My first question would be: do we have an actual problem with the current holders of commit rights? I'm not hearing about anybody abusing the system or exercising these rights wrongly, but maybe I'm just not listening in the right places (honestly!).

Not that I know of.

@RobLa-WMF: do you remember what the reason was back when this task was created (Sept 2014)? Maybe related to (the big, hairy topic of) code-review of gadgets?

greg edited projects, added Gerrit; removed Gerrit-Migration.Sep 9 2015, 5:45 PM
greg set Security to None.

(moving to the Gerrit project for now, we can add the migration project back if needed later)

RobLa-WMF removed RobLa-WMF as the assignee of this task.Jun 7 2016, 5:36 PM
demon moved this task from Bugs & stuff to Repo Admin on the Gerrit board.Jul 25 2016, 3:49 PM
demon closed this task as Invalid.Feb 5 2018, 11:43 PM
demon added a subscriber: demon.

This bug never really had a reason for existing. There's T62412 sorta related, but it's explicit in what it wants. Marking invalid unless someone can figure out why we wanted this.