Page MenuHomePhabricator

SkinMustache should provide standard portlet (menu) data
Closed, ResolvedPublic

Description

Currently SkinMustache requires all skins to manage their own code for menu generation. In T253938 we created a Skin method for creating portlets with the correct ID and classes.

All skins replicate the same logic and historically this has led to inconsistencies in markup e.g. T259401 and notably Minerva.

As we move more production skins onto SkinMustache I'd like to see these patterns generalized.

Benefits:

  • consistent labels (More #cactions dropdown is duplicated in Vector and Monobook)
  • consistent ID and classes across all SkinMustache-based skins - namely Vector and Example

Acceptance criteria

  • Skins using SkinMustache can render the standard MediaWiki menus without requiring the overriding of SkinMustache::getTemplateData

[] The Vector skin is showcasing the capability moved to T268157

Event Timeline

Change 624899 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Expose portlet data in SkinMustache

https://gerrit.wikimedia.org/r/624899

Change 624899 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Expose portlet data in SkinMustache

https://gerrit.wikimedia.org/r/624899

Change 624899 merged by jenkins-bot:
[mediawiki/core@master] Expose portlet data in SkinMustache

https://gerrit.wikimedia.org/r/624899

Change 624909 had a related patch set uploaded (by Ammarpad; owner: Jdlrobson):
[mediawiki/skins/Vector@master] WIP: Simplify menu code

https://gerrit.wikimedia.org/r/624909