Flow uses $wgUser
Closed, ResolvedPublic
Actions

Description

03:11:06 FILE: /workspace/src/extensions/Flow/includes/Content/BoardContent.php
03:11:06 ----------------------------------------------------------------------
03:11:06 FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
03:11:06 ----------------------------------------------------------------------
03:11:06  170 | WARNING | Deprecated global $wgUser used
03:11:06      |         | (MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgUser)
03:11:06 ----------------------------------------------------------------------
03:11:06 
03:11:06 
03:11:06 FILE: /workspace/src/extensions/Flow/includes/TalkpageManager.php
03:11:06 ----------------------------------------------------------------------
03:11:06 FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
03:11:06 ----------------------------------------------------------------------
03:11:06  158 | WARNING | Deprecated global $wgUser used
03:11:06      |         | (MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgUser)
03:11:06 ----------------------------------------------------------------------
03:11:06 
03:11:06 
03:11:06 FILE: /workspace/src/extensions/Flow/includes/TemplateHelper.php
03:11:06 ----------------------------------------------------------------------
03:11:06 FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
03:11:06 ----------------------------------------------------------------------
03:11:06  228 | WARNING | Deprecated global $wgUser used
03:11:06      |         | (MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgUser)
03:11:06 ----------------------------------------------------------------------

Blocking unrelated patches...

Codesearch: https://codesearch.wmcloud.org/deployed/?q=wgUser(%5B%3B%2C%27%22-%5D%7C%5Cs%7C%24)&i=nope&files=%5C.php%24&repos=mediawiki/extensions/Flow

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Flow	master	+18 -14	Replace $wgUser with RequestContext::getMain
	mediawiki/extensions/Flow	master	+3 -0	Ignore usage of $wgUser

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Resolved	DannyS712	T245959 WMF deployed extensions need uses of global $wgUser removed [tracking]
Resolved	DannyS712	T262111 Flow uses $wgUser

Event Timeline

Reedy created this task.Sep 5 2020, 2:38 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 5 2020, 2:38 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Reedy triaged this task as High priority.Sep 5 2020, 2:42 AM

Reedy added a parent task: T245959: WMF deployed extensions need uses of global $wgUser removed [tracking].Sep 5 2020, 2:49 AM

Change 625041 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Flow@master] Ignore usage of $wgUser

https://gerrit.wikimedia.org/r/625041

gerritbot added a project: Patch-For-Review.Sep 5 2020, 2:52 AM

Change 625041 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Ignore usage of $wgUser

https://gerrit.wikimedia.org/r/625041

Removing high and ci-test-error as blocker mitigated using phpcs:ignore

Uses still need migrating away at a later date, so leaving task as a subtask of T245959: WMF deployed extensions need uses of global $wgUser removed [tracking] for tracking of that work

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 5 2020, 4:00 AM

DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.Sep 11 2020, 7:13 PM

DannyS712 updated the task description. (Show Details)Sep 13 2020, 8:10 PM

Change 626904 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Replace $wgUser with RequestContext::getMain

https://gerrit.wikimedia.org/r/626904

gerritbot added a project: Patch-For-Review.Sep 14 2020, 5:25 AM

DannyS712 triaged this task as Medium priority.Sep 14 2020, 5:28 AM

DannyS712 added projects: Platform Team Workboards (External Code Reviews), User-DannyS712.

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.

Change 626904 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Replace $wgUser with RequestContext::getMain

https://gerrit.wikimedia.org/r/626904

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Dec 21 2020, 8:00 PM

Clarakosi moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.Dec 21 2020, 8:01 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 21 2020, 8:10 PM

DannyS712 closed this task as Resolved.Dec 22 2020, 1:10 AM

DannyS712 claimed this task.