Page MenuHomePhabricator

Extension WikiShare fails CI: PHP Fatal error: Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given
Closed, DeclinedPublic

Description

The hook SkinBuildSidebar does not allow raw html any more

PHP Fatal error:  Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given, called in /workspace/src/skins/Vector/includes/SkinVector.php on line 292 and defined in /workspace/src/skins/Vector/includes/SkinVector.php:327

Event Timeline

Ammarpad renamed this task from Extension WikiShare fails CI due to changes to the skin architecture to Extension WikiShare fails CI: PHP Fatal error: Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given.Sep 5 2020, 1:09 PM

I have renamed these tasks to more correct titles to make it clear the error was caused by the extensions since they're returning string where array is required.

The previous title makes it look like this was an error caused not by the extensions themselves.

As I already explained on Gerrit, this returning of HTML string was a legacy behavior that was deprecated and code was left working. It was later (in a different release 1.36, that support for the old behavior was removed), since it's not possible to continue supporting it forever.

Mayo3030 renamed this task from Extension WikiShare fails CI: PHP Fatal error: Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given to Messenger .Jan 25 2024, 9:05 AM
Mayo3030 closed this task as Resolved.
Mayo3030 claimed this task.
Mayo3030 set Due Date to Jan 25 2024, 12:00 AM.

<?xml versión="1.0"?>
<api>
<editmassmessagelist resultado= "Listo" > <agregado> < título de la página= "Conversación del usuario:Foo" desaparecido= "" /> </agregado> <invalidadd> <item título no válido = "" xml:space= "preservar" > _ </item> </invalidadd> <removed> <page title= "User talk:Baz" /> </removed> <invalidremove> <item> Baz </item> </invalidremove> </editmassmessagelist> </api>

Peachey88 renamed this task from Messenger to Extension WikiShare fails CI: PHP Fatal error: Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given.Jan 25 2024, 9:10 AM
Peachey88 reopened this task as Open.
Peachey88 removed Mayo3030 as the assignee of this task.
Peachey88 removed Due Date which was set to Jan 25 2024, 12:00 AM.
Peachey88 added a subscriber: Mayo3030.