Page MenuHomePhabricator
Create Task
Maniphest T262135

Extension SidebarDonateBox fails CI: PHP Fatal error: Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given
Closed, ResolvedPublic
Actions

Description

The hook SkinBuildSidebar does not allow raw html any more

PHP Fatal error:  Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given, called in /workspace/src/skins/Vector/includes/SkinVector.php on line 292 and defined in /workspace/src/skins/Vector/includes/SkinVector.php:327

Related Objects

Event Timeline

Umherirrender created this task.Sep 5 2020, 12:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2020, 12:33 PM
Umherirrender moved this task from Backlog to It's complicated on the MediaWiki-Core-Skin-Architecture board.Sep 5 2020, 12:35 PM
Ammarpad renamed this task from Extension SidebarDonateBox fails CI due to changes to the skin architecture to Extension SidebarDonateBox fails CI: PHP Fatal error: Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given.Sep 5 2020, 1:08 PM
Ammarpad removed a project: MediaWiki-Core-Skin-Architecture.
Ammarpad subscribed.Sep 5 2020, 1:21 PM

Renamed to more correct title. See T262134#6438231

Ammarpad unsubscribed.Sep 5 2020, 1:22 PM
Peachey88 added a subscriber: DanielFriesen.Sep 6 2020, 7:58 AM
Umherirrender unsubscribed.Nov 24 2021, 7:52 PM
Pppery closed this task as Resolved.Feb 28 2023, 11:48 PM
Pppery subscribed.

Tests for this extension now seem to be passing. Not sure what the fix was.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits