Page MenuHomePhabricator

Twinkle (enwiki) now uses a tag
Closed, ResolvedPublic

Description

The configuration for Twinkle on enwiki should support the new tag twinkle, which is now used instead of the link in the description. The tag has collected almost 1000 edits in under 24 hours; see Special:Tags for details.

This change has not been done on simplewiki, so no need to change it there.

Edit: Per the discussion below, the tag should also be added to tag_excludes for undo and rollback.

Event Timeline

The configuration should apply for single Twinkle tags. And single_tag should ignore PHP7 tags.

The configuration should apply for single Twinkle tags. And single_tag should ignore PHP7 tags.

Did I miss something? Why can't just every edit with the tag be counted?

Did I miss something? Why can't just every edit with the tag be counted?

I didn't mean that, some edits will tag something else with twinkle tag, (i.g mw-undo) as we also count mw-undo as CVN automated edits. so, we can't consider those edits as twinkle edits.

I don't think we do that usually (and AFAIK, we did count Twinkle reverts twice). There is the option tag_excludes in the configuration, so twinkle could be added as such to the configuration for mw-undo, but there is currently no parameter to exclude a specific regex from the results for a tool (as XTools looks for edits satisfying regex OR tag). If we add the tag as an exclusion, it would only make sense (and prevent confusion) if we add the regex for the link in the edit summary as an exclusion as well. Maybe you could create a task to add such a parameter if you think it's necessary?

I didn't mean that, some edits will tag something else with twinkle tag, (i.g mw-undo) as we also count mw-undo as CVN automated edits. so, we can't consider those edits as twinkle edits.

It should be the other way around based on the established use of tag_excludes. I think it's reasonable to add twinkle to tag-excludes for undo and rollback (STiki and Huggle did not always use tags either, but the configuration currently only excludes the tag), and I've edited the task description accordingly. As far as the edits before the implementation of the tag are concerned (this has already kind of been raised as an issue at T191133 two years ago), I agree regex_excludes would be a useful parameter.

MusikAnimal moved this task from Automated Edits to Pending deployment on the XTools board.
MusikAnimal added a subscriber: MusikAnimal.

I've added the twinkle tag, but unfortunately the tag_excludes functionality doesn't seem to work here, I believe for the same reasons as T191133. Overall I'm growing skeptical of the excludes system. It is very complicated to pull off, but furthermore it could be argued that these edits do constitute as use of Undo or Rollback -- as technically they are, just with a different edit summary. At any rate, I have twinkle specified in the tag_excludes, so whenever T191133 is fixed it should be fixed for Twinkle too.

MusikAnimal moved this task from Pending deployment to Complete on the XTools board.

Deployed