Remove ApiWatchlistTrait from ApiBase
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ammarpad
	Sep 7 2020, 12:08 AM

Description

ApiWatchlistTrait is not being used in ApiBase but is somehow 'needed' to be there. Its presence there now proves to be problematic.

To decouple it, some of the trait methods need to be updated to require User in their parameters.

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/FlaggedRevs	REL1_35	+26 -2	Update ApiWatchlistTrait::getWatchlistValue() call to provide user
mediawiki/core	REL1_35	+26 -30	Remove requirement for ApiWatchlistTrait to be in ApiBase.
mediawiki/extensions/FlaggedRevs	master	+6 -4	Update ApiWatchlistTrait::getWatchlistValue() call to provide user
mediawiki/core	master	+26 -30	Remove requirement for ApiWatchlistTrait to be in ApiBase.

Customize query in gerrit

Event Timeline

Ammarpad created this task.Sep 7 2020, 12:08 AM

Restricted Application added a project: Platform Engineering. · View Herald TranscriptSep 7 2020, 12:08 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 625574 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/FlaggedRevs@master] Update ApiWatchlistTrait::getWatchlistValue() call to provide user

https://gerrit.wikimedia.org/r/625574

gerritbot added a project: Patch-For-Review.Sep 7 2020, 12:10 AM

Change 624782 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Remove requirement for ApiWatchlistTrait to be in ApiBase.

https://gerrit.wikimedia.org/r/624782

daniel edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.Sep 8 2020, 5:07 PM

• eprodromou moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (External Code Reviews) board.Sep 8 2020, 8:27 PM

Change 624782 merged by jenkins-bot:
[mediawiki/core@master] Remove requirement for ApiWatchlistTrait to be in ApiBase.

https://gerrit.wikimedia.org/r/624782

Change 625574 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Update ApiWatchlistTrait::getWatchlistValue() call to provide user

https://gerrit.wikimedia.org/r/625574

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 11 2020, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 11 2020, 1:10 AM

Change 626526 had a related patch set uploaded (by Dmaza; owner: Ammarpad):
[mediawiki/core@REL1_35] Remove requirement for ApiWatchlistTrait to be in ApiBase.

https://gerrit.wikimedia.org/r/626526

gerritbot added a project: Patch-For-Review.Sep 11 2020, 2:56 AM

Change 626526 merged by jenkins-bot:
[mediawiki/core@REL1_35] Remove requirement for ApiWatchlistTrait to be in ApiBase.

https://gerrit.wikimedia.org/r/626526

Maintenance_bot removed a project: Patch-For-Review.Sep 11 2020, 4:10 AM

Change 626670 had a related patch set uploaded (by Reedy; owner: Ammarpad):
[mediawiki/extensions/FlaggedRevs@REL1_35] Update ApiWatchlistTrait::getWatchlistValue() call to provide user

https://gerrit.wikimedia.org/r/626670

gerritbot added a project: Patch-For-Review.Sep 11 2020, 2:56 PM

Change 626670 abandoned by Reedy:
[mediawiki/extensions/FlaggedRevs@REL1_35] Update ApiWatchlistTrait::getWatchlistValue() call to provide user

Reason:
looks like this isn't needed as Ifab1490d7a7ed1d9321addd5fb2fcf238b30c81a didn't come in during REL1_35...

https://gerrit.wikimedia.org/r/626670

Ammarpad closed this task as Resolved.Sep 11 2020, 3:36 PM

Ammarpad claimed this task.

Ammarpad removed a project: Patch-For-Review.Sep 11 2020, 5:05 PM