Upgrade Gerrit to 3.3
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Sep 8 2020, 7:25 AM

Description

Gerrit has published their release plan for 3.3 with an expected release date on 2020-11-09: https://www.gerritcodereview.com/2020-09-07-gerrit-3.3-release-plan.html

See Gerrit (Gerrit 3.3) milestone for all related activities.

Date	Activity
Oct 5	Set language level to Java 11 on master
Oct 6	Create stable-3.3 branch, Release ‘3.3.0-rc0’
Oct 12	Release 3.3.0-rc1
Oct 19	Release 3.3.0-rc2
Oct 26	Release 3.3.0-rc3
Nov 2	Release 3.3.0-rc4
Nov 2-6	“Release week” (see below)
Nov 9	Final release of 3.3.0
Dec 1st	3.3.0 has been released https://www.gerritcodereview.com/3.3.html

At a quick glance:

they will use end to end tests \o/ ( https://gerrit-review.googlesource.com/Documentation/dev-e2e-tests.html )

we use java 8, although 3.3 will still support being build with it, upstream strongly suggest to switch to java 11: https://www.gerritcodereview.com/2020-09-07-gerrit-3.3-release-plan.html#java

Update:

We are running Java 11

The sole breaking change is log timestamp receiving milliseconds which does not seem to be a problem for us (details: T287379 ).

Details

Project	Branch	Lines +/-	Subject
operations/software/gerrit	deploy/wmf/stable-3.3	+13 -13	Gerrit 3.3.5 + plugins
operations/software/gerrit	wmf/stable-3.3	+24 -19	Merge branch 'wmf/stable-3.2' into wmf/stable-3.3
operations/software/gerrit/plugins/gitiles	wmf/stable-3.3	+0 -0	Merge 'wmf/stable-3.2' into wmf/stable-3.3
operations/puppet	production	+2 -0	gerrit: explicitly set jgit receive.autogc=false

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	hashar	T131968 Outgoing and recently closed reviews that have new comments should be marked as bold just as the incoming reviews
Resolved	dancy	T262241 Upgrade Gerrit to 3.3
Resolved	None	T270472 Gerrit errors on change #650396, missing blob
Resolved	hashar	T268225 Switch Gerrit from Java 8 to Java 11
Resolved	None	T278990 Upgrade Gerrit to 3.2.11
Resolved	colewhite	T283347 Add dancy to `archiva-deployers` LDAP group

Event Timeline

hashar created this task.Sep 8 2020, 7:25 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 8 2020, 7:25 AM

hashar triaged this task as Medium priority.Sep 8 2020, 7:25 AM

Mentioned in SAL (#wikimedia-releng) [2020-11-04T19:59:54Z] <hashar> operations/software/gerrit : pushed upstream git tag, synced the master branch # T262241

3.3.0 has been released https://www.gerritcodereview.com/3.3.html

hashar added a subtask: T270472: Gerrit errors on change #650396, missing blob.Dec 22 2020, 10:20 AM

hashar added a subtask: T268225: Switch Gerrit from Java 8 to Java 11.

The rough order:

blocker upgrade to Java 11 T268225
If at all possible setup CI jobs using Bazelisk to build Gerrit and the plugins we need
(stretch goal) Get the rename plugin T201953 and write the runbook to rename a repo
Update https://gerrit.devtools.wmflabs.org/
- (stretch goal) add an authentication system to the devtool
blocker ensure bot users to a new group Service Users (If I got it right, the upgrade should rename the Non-Interactive Users group) (schema 184).
blocker review http://gerrit-documentation.storage.googleapis.com/Documentation/3.3.0/user-attention-set.html and advertise it to the user. Possibly via a presentation? Might require the instance on devtools to be fixed up first.

hashar mentioned this in T263008: Gerrit out of heap.Dec 22 2020, 11:49 AM

hashar added a parent task: T263008: Gerrit out of heap.

hashar removed a parent task: T263008: Gerrit out of heap.Dec 24 2020, 11:40 AM

hashar added a parent task: T131968: Outgoing and recently closed reviews that have new comments should be marked as bold just as the incoming reviews.Dec 30 2020, 3:24 PM

hashar mentioned this in T131968: Outgoing and recently closed reviews that have new comments should be marked as bold just as the incoming reviews.

hashar edited projects, added Gerrit (Gerrit 3.3); removed Gerrit.Jan 5 2021, 2:36 PM

thcipriani moved this task from INBOX to Maintenance on the Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)) board.Jan 5 2021, 5:26 PM

hashar claimed this task.Jan 11 2021, 8:55 AM

hashar updated the task description. (Show Details)

Meno25 added a subscriber: Meno25.Feb 22 2021, 8:07 PM

thcipriani edited projects, added Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)); removed Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)).Apr 20 2021, 12:37 AM

thcipriani removed a project: Release-Engineering-Team (Development services).Apr 20 2021, 1:22 AM

thcipriani edited projects, added Release-Engineering-Team (Doing); removed Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)).Apr 20 2021, 4:25 AM

hashar closed subtask T268225: Switch Gerrit from Java 8 to Java 11 as Resolved.Jun 7 2021, 1:50 PM

hashar added a subtask: T278990: Upgrade Gerrit to 3.2.11.Jul 13 2021, 5:57 PM

hashar closed subtask T278990: Upgrade Gerrit to 3.2.11 as Resolved.Jul 19 2021, 7:32 PM

Next is to upgrade Gerrit to 3.3 :-] I would like to do it next week if we are good enough.

Change 705929 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit/plugins/gitiles@wmf/stable-3.3] Merge 'wmf/stable-3.2' into wmf/stable-3.3

https://gerrit.wikimedia.org/r/705929

gerritbot added a project: Patch-For-Review.Jul 21 2021, 3:04 PM

Change 705934 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@wmf/stable-3.3] Merge branch 'wmf/stable-3.2' into wmf/stable-3.3

https://gerrit.wikimedia.org/r/705934

hashar updated the task description. (Show Details)Jul 26 2021, 2:29 PM

Change 708502 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/puppet@production] gerrit: explicitly set jgit receive.autogc=false

https://gerrit.wikimedia.org/r/708502

Change 708502 merged by Dzahn:

[operations/puppet@production] gerrit: explicitly set jgit receive.autogc=false

https://gerrit.wikimedia.org/r/708502

The upgrade is scheduled for Tuesday August 3rd at 16:00 UTC.

Things we have checked based on the release notes at https://www.gerritcodereview.com/3.3.html

Java 11 by default for Gerrit	We have switched to java 11 some months ago T268225
New logs timestamp format	Logstash should works fine with the new format T287379
Attention set	Mentioned in the maintenance announce (upstream doc)
Patchset level comments	3.3 is back compatible. 3.4 unknown: T287385