Page MenuHomePhabricator

Save Timing regression on 2020-09-07 at 18:04 UTC
Closed, ResolvedPublic

Description

The timing corresponds exactly to this deployment:

18:04 urbanecm@deploy1001: Synchronized private/PrivateSettings.php: Update T250887 mitigations (duration: 00m 56s)

This doubled the amount of time it takes for edits to be saved.

@Urbanecm I would advise reverting that change. This will confirm that it was the source of the regression. And the revert will give us time to find a performance-friendly way to solve this problem without a continued regression in the meantime.

Event Timeline

Gilles created this task.Tue, Sep 8, 7:27 AM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptTue, Sep 8, 7:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Gilles triaged this task as Unbreak Now! priority.Tue, Sep 8, 7:27 AM
Gilles updated the task description. (Show Details)
Gilles updated the task description. (Show Details)

Mentioned in SAL (#wikimedia-operations) [2020-09-08T07:44:49Z] <urbanecm@deploy1001> Synchronized private/PrivateSettings.php: Revert "Update T250887 mitigations" (T250887; T262242) (duration: 00m 59s)

Thanks @Gilles. I've reverted that change. I'm also CCing @sbassett, as I discussed the change with him, and was reviewed by him.

Gilles closed this task as Resolved.Tue, Sep 8, 7:50 AM

Thanks, the revert confirms that this was the source of the regression:

Peter added a subscriber: Peter.Tue, Sep 8, 10:41 AM