Page MenuHomePhabricator

Fix toolsdb puppetization broken by upstream refactor
Closed, ResolvedPublic

Description

Now that https://gerrit.wikimedia.org/r/c/operations/puppet/+/624669 is merged, ToolsDB puppet is broken.

Error from puppet:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Function lookup() did not find a value for the name 'profile::mariadb::section_ports' (file: /etc/puppet/modules/profile/manifests/mariadb/wmfmariadbpy.pp, line: 4) on node clouddb1001.clouddb-services.eqiad.wmflabs

Just have to find where to to put that to make puppet find it.

Event Timeline

Bstorm triaged this task as Medium priority.Sep 8 2020, 5:31 PM
Bstorm created this task.
Bstorm moved this task from Inbox to Doing on the cloud-services-team (Kanban) board.
Bstorm added a subscriber: Kormat.

Ok, so I copied the contents of the profile::mariadb::section_ports key into horizon prefix puppet, and this restores things.
I'd rather not have multiple sources of truth on this list, if possible, even though it is not actually used on VM-based databases yet.
There are some differences between cloud and production hiera lookups that may be in play here (see T255787).

It could just be that profile::mariadb isn't used?

profile::mariadb::section_ports is currently used to generate /etc/wmfmariadbpy/section_ports.csv on db hosts. It will be used (Real Soon Now) for multiinstance puppet profiles.

I don't know enough about the cloud hiera differences; it would definitely be nice if we didn't need to duplicate that hiera key.

I think this is fine now. I did introduce the section_ports in the cloud.yaml hiera to make sure it's not a problem in the future.