Page MenuHomePhabricator

TypeError: node is null ( at ve.adjacentDomPosition )
Closed, ResolvedPublicPRODUCTION ERROR

Description

Details

Request ID
undefined
Request URL
n/a
Stack Trace
exception.trace
TypeError: node is null
at ve.adjacentDomPosition URL1:1551:223
at ve.ce.Document.prototype.getNodeAndOffset URL1:437:191
at ve.ce.Surface.prototype.annotationsAtModelSelection URL1:564:215
at ve.ce.Surface.prototype.onDocumentMouseDown URL1:504:739
at dispatch URL2:251:742
at add/elemData.handle URL2:248:388

URL1: https://ca.wikipedia.org/w/load.php?lang=ca&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2Cicons%2Clanguage%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector&version=zd0la
URL2: https://ca.wikipedia.org/w/load.php?lang=ca&modules=ext.centralNotice.bannerHistoryLogger%2CchoiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2ClargeBannerLimit%2ClegacySupport%2CstartUp%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.cite.ux-enhancements%7Cext.cx.entrypoints.contributionsmenu%7Cext.cx.eventlogging.campaigns%7Cext.cx.interlanguagelink.init%7Cext.cx.widgets.callout%7Cext.echo.api%2Cinit%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.quicksurveys.init%2Clib%7Cext.uls.common%2Ccompactlinks%2Cinit%2Cinterface%2Cpreferences%2Cwebfonts%7Cext.wikimediaEvents.loggedin%7Cjquery%2Coojs%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%2Csite%7Cjquery.client%2Ccookie%2Cspinner%2CtextSelection%7Cjquery.spinner.styles%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cnotification%2Cstorage%2Cuser%2Cutil%2Cviewport%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.action.view.postEdit%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmediawiki.ui.button%7Cmw.config.values.wbDataBridgeConfig%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.indicators%7Cskins.vector.legacy.js%7Cuser.defaults%7Cwikibase.client.data-bridge.init%7Cwikibase.client.linkitem.init&skin=vector&version=1fs4r

Event Timeline

Change 628076 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in annotationsAtModelSelection

https://gerrit.wikimedia.org/r/628076

This one is a bit concerning because it isn't from a throw, so we should still see if we can reproduce this somehow. CC @dchan

Change 628076 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in annotationsAtModelSelection

https://gerrit.wikimedia.org/r/628076

Change 628077 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (53af216aa)

https://gerrit.wikimedia.org/r/628077

Change 628077 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (53af216aa)

https://gerrit.wikimedia.org/r/628077

matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex added a subscriber: matmarex.

Instead of QA, we should check the logs to confirm this error has disappeared after the patches are deployed.

Change 640098 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Catch errors from adjacentDomPosition in LinearDeleteKeyDownHandler

https://gerrit.wikimedia.org/r/640098

Change 640098 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Avoid errors from adjacentDomPosition in LinearDeleteKeyDownHandler

https://gerrit.wikimedia.org/r/640098

Change 641268 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b37f95f1)

https://gerrit.wikimedia.org/r/641268

Change 641268 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b37f95f1)

https://gerrit.wikimedia.org/r/641268