- Exclude “search” from that stack (in same way we do in current navigation) - First article tapped from search includes search in the stack, next article removes search
- If easy, add in (SF Symbol?) icons for search/articles/etc. to start of string
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T256416 iOS 14 Updates | |||
| Resolved | • JMinor | T258216 iOS14 [Feature]: Investigate nav bar long pressing to solve back back back issue | |||
| Resolved | • MattCleinman | T262305 iOS 14 long-pressing back button: Design improvements |
Event Timeline
Comment Actions
As for number 2 - would have to be unicode (including emojis), not SF Symbol. SF Symbol reads in as an image, and we can just use strings here.
Comment Actions
Regarding the first bullet -
While we remove unneeded SearchControllers via the Navigation Controller's delegate (in navigationController didShowViewController), we rebuild the navigation items in the View Controller's viewWillAppear. The problem is that the latter function is firing before the former, so we're building the nav item stack before we prune out Search VCs. (That means that with one more tap into another article, the SearchVC no longer appears in the nav item - removing search VCs from the long-press back menu is off by one.)
Moving the nav controller work into navigationController willShowViewController doesn't make it fire first.
Order of operations:
VC willAppear
Nav willShow
VC didAppeaer
Nav didShow
Need a little refactor here to make this work.
Comment Actions
Talked w/ @cmadeo - We're not going to add icons (per second bullet), as the emojis looked too unrefined.
