Page MenuHomePhabricator
Create Task
Maniphest T262396

API Gateway doesn't respect mwdebug headers
Closed, ResolvedPublic
Actions

Description

The API gateway currently directly requests pages from the appservers, meaning that our standard workflow around using mwdebug to test changes is broken and the only way to verify changes is via curl on the staging instances. This is obviously far from ideal.

The API gateway should interpret and respect the X-Mediawiki-Debug header in order to mimic behaviour used on regular deployments.

Details

SubjectRepoBranchLines +/-
api-gateway: allow mwdebug hosts in calicooperations/deployment-chartsmaster+14 -0
api-gateway: Add all mwdebug hosts to debug clustersoperations/deployment-chartsmaster+48 -0
api-gateway: allow prod instances to hit mwdebugoperations/deployment-chartsmaster+24 -0
Api-gateway: Implement support for X-Wikimedia-Debug headeroperations/deployment-chartsmaster+68 -8
Customize query in gerrit

Related Objects

Event Timeline

hnowlan created this task.Sep 9 2020, 11:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2020, 11:33 AM
hnowlan triaged this task as Medium priority.Sep 9 2020, 11:34 AM
hnowlan added a project: Platform Team Initiatives (API Gateway).
• Pchelolo claimed this task.Sep 15 2020, 5:37 PM
• Pchelolo raised the priority of this task from Medium to High.
• Pchelolo moved this task from Backlog to Doing on the Platform Team Workboards (Green) board.
• Pchelolo added subscribers: CCicalese_WMF, • Pchelolo.

I want to retriage this to high. This makes deploys for API Portal very risky since we can't test the patches as we've discovered with @CCicalese_WMF recently. let's fix it.

gerritbot added a comment.Sep 15 2020, 7:15 PM

Change 627588 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/deployment-charts@master] Api-gateway: Implement support for X-Wikimedia-Debug header

https://gerrit.wikimedia.org/r/627588

gerritbot added a project: Patch-For-Review.Sep 15 2020, 7:15 PM
gerritbot added a comment.Sep 16 2020, 2:24 PM

Change 627588 merged by jenkins-bot:
[operations/deployment-charts@master] Api-gateway: Implement support for X-Wikimedia-Debug header

https://gerrit.wikimedia.org/r/627588

• eprodromou subscribed.EditedSep 16 2020, 2:31 PM

@Pchelolo could you explain what this is supposed to do? I'm not familiar with X-Wikimedia-Debug.

• eprodromou mentioned this in T263029: Limit X-Wikimedia-Debug handling to particular client IDs.Sep 16 2020, 2:41 PM

Correction, I found it. https://wikitech.wikimedia.org/wiki/WikimediaDebug .

It sounds useful, but... this is the kind of debug functionality that becomes an undocumented feature. I'd like to see it limited by client ID.

It's not a high priority. I added T263029 to track it.

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2020, 3:10 PM
WDoranWMF moved this task from Doing to Waiting for Review on the Platform Team Workboards (Green) board.Sep 16 2020, 3:51 PM
gerritbot added a comment.Sep 16 2020, 4:55 PM

Change 627882 had a related patch set uploaded (by Hnowlan; owner: Hnowlan):
[operations/deployment-charts@master] api-gateway: allow prod instances to hit mwdebug

https://gerrit.wikimedia.org/r/627882

gerritbot added a project: Patch-For-Review.Sep 16 2020, 4:55 PM
gerritbot added a comment.Sep 16 2020, 5:12 PM

Change 627882 merged by jenkins-bot:
[operations/deployment-charts@master] api-gateway: allow prod instances to hit mwdebug

https://gerrit.wikimedia.org/r/627882

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2020, 6:10 PM
gerritbot added a comment.Sep 17 2020, 10:52 AM

Change 628066 had a related patch set uploaded (by Hnowlan; owner: Hnowlan):
[operations/deployment-charts@master] api-gateway: Add all mwdebug hosts to debug clusters

https://gerrit.wikimedia.org/r/628066

gerritbot added a project: Patch-For-Review.Sep 17 2020, 10:52 AM
gerritbot added a comment.Sep 17 2020, 2:12 PM

Change 628066 merged by jenkins-bot:
[operations/deployment-charts@master] api-gateway: Add all mwdebug hosts to debug clusters

https://gerrit.wikimedia.org/r/628066

Maintenance_bot removed a project: Patch-For-Review.Sep 17 2020, 3:10 PM
gerritbot added a comment.Sep 17 2020, 3:45 PM

Change 628127 had a related patch set uploaded (by Hnowlan; owner: Hnowlan):
[operations/deployment-charts@master] api-gateway: allow mwdebug hosts in calico

https://gerrit.wikimedia.org/r/628127

gerritbot added a project: Patch-For-Review.Sep 17 2020, 3:45 PM
gerritbot added a comment.Sep 18 2020, 9:59 AM

Change 628127 merged by jenkins-bot:
[operations/deployment-charts@master] api-gateway: allow mwdebug hosts in calico

https://gerrit.wikimedia.org/r/628127

Maintenance_bot removed a project: Patch-For-Review.Sep 18 2020, 10:10 AM
hnowlan added a comment.Sep 18 2020, 10:33 AM

All mwdebug servers now work in API gateway

• Pchelolo added a comment.Sep 18 2020, 1:32 PM

So, resolved?

hnowlan moved this task from Waiting for Review to Done on the Platform Team Workboards (Green) board.Sep 18 2020, 1:54 PM
• Pchelolo closed this task as Resolved.Oct 2 2020, 7:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL