Page MenuHomePhabricator

[TRACKING] Selser issues on talk pages
Open, HighPublic

Event Timeline

Esanders created this task.Sep 9 2020, 1:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2020, 1:22 PM
Esanders updated the task description. (Show Details)Sep 9 2020, 1:43 PM

The two whitespace issues (T262409 & T262410) appear to account for the majority of corruption we are seeing, if you want to prioritise your focus.

ssastry added a subscriber: ssastry.Sep 9 2020, 2:48 PM

This below reproduces both the bugs.

[subbu@earth:~/work/wmf/parsoid] echo -e "*  a \n** b \n" > /tmp/wt
[subbu@earth:~/work/wmf/parsoid] php bin/parse.php < /tmp/wt > /tmp/old.html
[subbu@earth:~/work/wmf/parsoid] sed 's/b<\/li>/b<\/li>\n<li>b-new<\/li>/g;' < /tmp/old.html > /tmp/new.html
[subbu@earth:~/work/wmf/parsoid] php bin/parse.php --html2wt --selser --oldtextfile /tmp/wt --oldhtmlfile /tmp/old.html< /tmp/new.html > /tmp/edited.wt
[subbu@earth:~/work/wmf/parsoid] diff /tmp/wt /tmp/edited.wt
1,3c1,3
< *  a 
< ** b 
< 
---
> * a 
> ** b
> ** b-new
ppelberg moved this task from Backlog to Blocked by others on the Editing-team (Tracking) board.
ppelberg added a subscriber: ppelberg.
ssastry triaged this task as Medium priority.Sep 10 2020, 5:26 PM
ssastry moved this task from Needs Triage to Current & Upcoming Work on the Parsoid board.

Change 628937 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: Selser: Preprocess doms to wrap li text nodes in wrapper

https://gerrit.wikimedia.org/r/628937

Change 630219 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Record trimmed whitespace in additional DSR fields

https://gerrit.wikimedia.org/r/630219

ssastry raised the priority of this task from Medium to High.Thu, Oct 1, 4:39 PM

Change 630219 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Record length of trimmed whitespace in additional DSR fields

https://gerrit.wikimedia.org/r/630219

Change 635100 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a12

https://gerrit.wikimedia.org/r/635100

Change 635100 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a12

https://gerrit.wikimedia.org/r/635100