Page MenuHomePhabricator
Create Task
Maniphest T262409

Space at end of another list item removed
Closed, ResolvedPublic
Actions

Description

It appears to always be the first list item in a parent list node that gets modified:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.13.0-a10mediawiki/vendormaster+415 -168
Refine source reusability check for nested list itemsmediawiki/services/parsoidmaster+42 -20
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT262408 [TRACKING] Selser issues on talk pages
 ResolvedssastryT262409 Space at end of another list item removed

Event Timeline

Esanders created this task.Sep 9 2020, 1:30 PM
Esanders updated the task description. (Show Details)Sep 9 2020, 1:34 PM
Esanders renamed this task from Space at end of another list item removed: to Space at end of another list item removed.Sep 9 2020, 1:46 PM
Esanders added a comment.Sep 9 2020, 2:03 PM

My simple attempt to reproduce this failed: https://www.mediawiki.org/w/index.php?title=User:ESanders_(WMF)/sandbox&type=revision&diff=4091858&oldid=4091857&diffmode=source

Esanders mentioned this in T262408: [TRACKING] Selser issues on talk pages.Sep 9 2020, 2:04 PM
gerritbot added a comment.Sep 10 2020, 1:44 PM

Change 626381 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Refine source reusability check for nested list items

https://gerrit.wikimedia.org/r/626381

gerritbot added a project: Patch-For-Review.Sep 10 2020, 1:44 PM
ssastry triaged this task as Medium priority.Sep 10 2020, 5:23 PM
ssastry moved this task from Needs Triage to Current & Upcoming Work on the Parsoid board.
Esanders added a comment.Sep 11 2020, 1:48 PM

Is this related: T257651#6453897 ?

gerritbot added a comment.Sep 15 2020, 11:07 PM

Change 626381 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Refine source reusability check for nested list items

https://gerrit.wikimedia.org/r/626381

Maintenance_bot removed a project: Patch-For-Review.Sep 15 2020, 11:10 PM
ssastry closed this task as Resolved.Sep 17 2020, 6:00 PM
ssastry claimed this task.
ssastry subscribed.

This will ride the train next week.

gerritbot added a comment.Sep 21 2020, 9:06 PM

Change 628944 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a10

https://gerrit.wikimedia.org/r/628944

gerritbot added a project: Patch-For-Review.Sep 21 2020, 9:06 PM
gerritbot added a comment.Sep 21 2020, 10:30 PM

Change 628944 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a10

https://gerrit.wikimedia.org/r/628944

Maintenance_bot removed a project: Patch-For-Review.Sep 21 2020, 11:11 PM
cscott added a comment.EditedOct 6 2020, 4:00 PM

According to editing team, this patch greatly reduced the number of dirty diffs, from ~4% before this patch rolled out to ~0.75%. Hopefully the rest of the patches in the 'preserve trimmed whitespace' series will crush this even lower.

Esanders added a comment.Oct 6 2020, 4:23 PM

Dirty diff rate:

image.png (437×685 px, 40 KB)

Esanders awarded a token.Oct 6 2020, 4:23 PM
ssastry added a comment.Oct 6 2020, 5:09 PM

Good to know! I am surprised that trailing whitespace in list items is that common.

Esanders mentioned this in T269017: Empty list item has whitespace removed.Nov 30 2020, 5:13 PM
Esanders reopened this task as Open.Dec 11 2020, 11:32 AM

I think this might have regressed in wmf21, there were 3 instances yesterday: https://dtcheck.toolforge.org/dtcheck-2020-12-10.html

ssastry closed this task as Resolved.Dec 11 2020, 2:29 PM

I am going to close this since I created T269901: Dirty diff: Single additional trailing whitespace added to several discussion tools edits in last 3+ weeks for those diffs.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits