Page MenuHomePhabricator

Poorly-built mediawiki/core package-lock.json means upgrades to package.json fail CI
Closed, ResolvedPublic

Description

Bug

I have noticed ESLint errors to cause some jobs to fail on the CI for mediawiki/core.

Error Message

Particularly, this is the error that I get:

08:57:51 /src/tests/selenium/wdio-mediawiki/index.js
08:57:51   1:1  error  Definition for rule 'no-promise-executor-return' was not found  no-promise-executor-return
08:57:51   1:1  error  Definition for rule 'no-unreachable-loop' was not found         no-unreachable-loop
08:57:51 
08:57:51 /src/tests/selenium/wdio-mediawiki/package.json
08:57:51   1:2  error  Definition for rule 'no-promise-executor-return' was not found  no-promise-executor-return
08:57:51   1:2  error  Definition for rule 'no-unreachable-loop' was not found         no-unreachable-loop
08:57:51 
08:57:51 /src/tests/selenium/wdio-mediawiki/specs/BlankPage.js
08:57:51   1:1  error  Definition for rule 'no-promise-executor-return' was not found  no-promise-executor-return
08:57:51   1:1  error  Definition for rule 'no-unreachable-loop' was not found         no-unreachable-loop
08:57:51 
08:57:51 /src/tests/selenium/wdio.conf.js
08:57:51   1:1  error  Definition for rule 'no-promise-executor-return' was not found  no-promise-executor-return
08:57:51   1:1  error  Definition for rule 'no-unreachable-loop' was not found         no-unreachable-loop
08:57:51 
08:57:51 ✖ 1509 problems (1505 errors, 4 warnings)
08:57:51 
08:57:51 Warning: Task "eslint:all" failed. Use --force to continue.
08:57:51 
08:57:51 Aborted due to warnings.
08:57:51 npm ERR! code ELIFECYCLE
08:57:51 npm ERR! errno 3
08:57:51 npm ERR! @ test: `grunt lint && npm run doc`
08:57:51 npm ERR! Exit status 3
08:57:51 npm ERR! 
08:57:51 npm ERR! Failed at the @ test script.
08:57:51 npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
08:57:51 
08:57:51 npm ERR! A complete log of this run can be found in:
08:57:51 npm ERR!     /cache/_logs/2020-09-09T03_27_51_228Z-debug.log

Link to the complete error log

https://integration.wikimedia.org/ci/job/mwgate-node10-docker/158888/console

Steps to Reproduce:

  1. Clone mediawiki/core repo
  2. Submit a patch to the CI by making a minor change
  3. jenkins-bot will likely complain about the ESLint errors and give the patch a -1.

Details

Related Changes in Gerrit:

Event Timeline

Soham triaged this task as Medium priority.Sep 9 2020, 4:06 PM

Both rules are added with ESLint 7.3.0

package-lock.json point to eslint 7.7.0, that sounds fine.

npm ci is shown in the results

Not sure what happens

Both rules are added with ESLint 7.3.0

package-lock.json point to eslint 7.7.0, that sounds fine.

npm ci is shown in the results

Not sure what happens

It is still a problem. I tried deleting the node_modules and did a fresh install but got the same error locally.

Change 616714 had a related patch set uploaded (by Jforrester; owner: AlQaholic007):
[mediawiki/core@master] build: Auto-fix npm audit issues

https://gerrit.wikimedia.org/r/616714

I've re-built package-lock in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/616714 and pulled your patch on top of it, which now passes.

Change 616714 merged by jenkins-bot:
[mediawiki/core@master] build: Auto-fix npm audit issues

https://gerrit.wikimedia.org/r/616714

Jdforrester-WMF renamed this task from ESLint causes mwgate-node10-docker job to fail on the CI for mediawiki/core to Poorly-built mediawiki/core package-lock.json means upgrades to package.json fail CI.Sep 10 2020, 4:08 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF claimed this task.
Jdforrester-WMF removed a project: Patch-For-Review.