SpecialPage.php - remove unused properties from the constructor which are not used
Open, LowPublic
Actions

Assigned To

None

Authored By

	Art.tsymbar
	Sep 9 2020, 4:54 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Art.tsymbar

Reedy

Description

There are 2 properties ( $function = false, $file = '' ) in the __constructor() of the includes\specialpage\SpecialPage.php file which are not used and are to be removed.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	SpecialPage: Remove deprecated constructor parameters and properties	Fomafix	mediawiki/core	master	+17 -96
	SpecialPage: Hard deprecate unused constructor parameters	Fomafix	mediawiki/core	master	+19 -10

Customize query in gerrit

Related Objects

Mentioned In: T416793: Improve SpecialPage and intermediate subclasses

Event Timeline

Art.tsymbar created this task.Sep 9 2020, 4:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2020, 4:54 PM

Art.tsymbar renamed this task from SpecialPage.php - remove unused properties from the constructor. to SpecialPage.php - remove unused properties from the constructor which are not used..Sep 9 2020, 4:56 PM

Reedy renamed this task from SpecialPage.php - remove unused properties from the constructor which are not used. to SpecialPage.php - remove unused properties from the constructor which are not used.Sep 9 2020, 6:12 PM

Reedy added a project: Technical-Debt.

Note, these really need deprecating before being removed, as you're going to be changing the order of parameters passed to the constructor... And I'd imagine there's some subclasses that pass all the parameters so they can set $includable to true

Helga_sf triaged this task as Low priority.Oct 19 2020, 3:45 PM

Peter.ovchyn removed Art.tsymbar as the assignee of this task.Oct 21 2020, 12:35 PM

Pppery edited projects, added: MediaWiki-Special-pages; removed: MediaWiki-General.Mar 7 2026, 8:22 PM

Pppery moved this task from To triage to SpecialPage system on the MediaWiki-Special-pages board.

Pppery mentioned this in T416793: Improve SpecialPage and intermediate subclasses.

Change #1237644 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] SpecialPage: Hard deprecate unused constructor parameters

https://gerrit.wikimedia.org/r/1237644

gerritbot added a project: Patch-For-Review.Mar 8 2026, 6:56 PM

Change #1235480 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] SpecialPage: Remove deprecated constructor parameters and properties

https://gerrit.wikimedia.org/r/1235480

Change #1237644 merged by jenkins-bot: