Page MenuHomePhabricator

SpecialPage.php - remove unused properties from the constructor which are not used
Open, LowPublic

Description

There are 2 properties ( $function = false, $file = '' ) in the __constructor() of the includes\specialpage\SpecialPage.php file which are not used and are to be removed.

Event Timeline

Art.tsymbar renamed this task from SpecialPage.php - remove unused properties from the constructor. to SpecialPage.php - remove unused properties from the constructor which are not used..Sep 9 2020, 4:56 PM
Reedy renamed this task from SpecialPage.php - remove unused properties from the constructor which are not used. to SpecialPage.php - remove unused properties from the constructor which are not used.Sep 9 2020, 6:12 PM
Reedy added a project: Technical-Debt.

Note, these really need deprecating before being removed, as you're going to be changing the order of parameters passed to the constructor... And I'd imagine there's some subclasses that pass all the parameters so they can set $includable to true