Page MenuHomePhabricator

Review Reply Tool test protocol
Closed, ResolvedPublic

Description

This task is about ensuring the Reply Tool testing protocol is accurate and exhaustive.

Background

Prior to deploying the Reply Tool as an opt-our preference (T249394), we would like to do our best to ensure it's working in the way we and volunteers expect.

Open questions

The questions below pertain to the Reply Tool testing protocol's "Template" sheet:

  • What – if any – "Test cases" should be added to the "Template" sheet? Please add them.
  • Which – if any – of the existing "Test cases" depend on in-progress patches? Where "depend" means a patch being merged could cause a test case to change from having Passed QA to Failing QA. Please link the tickets associated with these patches in the "Related ticket(s)" column.

Done

  • All "Open questions" are answered

Event Timeline

What – if any – "Test cases" should be added to the "Template" sheet? Please add them.

I don't have any suggestions, the list you have seems to cover the common cases quite well. I was going to suggest the test cases from the last time (T252558) but I see they are already included.

A few of the test cases are a bit redundant, e.g. these all sound like the same thing to me:

  • Verify from the diff that, no extraneous syntax/content has been added to the comment
  • Verify that, no unexpected wikitext appears
  • Verify from the diff that, no extraneous syntax/content has been added to the comment

Which – if any – of the existing "Test cases" depend on in-progress patches? Where "depend" means a patch being merged could cause a test case to change from having Passed QA to Failing QA. Please link the tickets associated with these patches in the "Related ticket(s)" column.

The only thing I could think of is T257305: Allow multiple replies to be drafted at the same time in regard to this item:

  • Open and close the Reply Tool in many places on a single page and ensure the tool opens and closes properly.

But that only had an experimental patch, it's still waiting for a new design, so any changes are unlikely to happen soon.

This is great – thank you for reviewing this, @matmarex.

As @Ryasmeen and I talked about today, T261477 can now be worked on.