Call to a member function preSaveTransform() on boolean
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.6

message

Call to a member function preSaveTransform() on boolean

Impact

Notes

Details

Request ID: 16b83802-80e1-4619-bb0f-aca38336827e
Request URL: https://en.wikipedia.org/w/index.php?title=Millbrook_School&action=submit

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.36.0-wmf.6/includes/EditPage.php(2469): EditPage->isUndoClean(WikitextContent)
#1 /srv/mediawiki/php-1.36.0-wmf.6/includes/EditPage.php(1739): EditPage->internalAttemptSave(array, boolean)
#2 /srv/mediawiki/php-1.36.0-wmf.6/includes/EditPage.php(681): EditPage->attemptSave(array)
#3 /srv/mediawiki/php-1.36.0-wmf.6/includes/actions/EditAction.php(71): EditPage->edit()
#4 /srv/mediawiki/php-1.36.0-wmf.6/includes/actions/SubmitAction.php(38): EditAction->show()
#5 /srv/mediawiki/php-1.36.0-wmf.6/includes/MediaWiki.php(527): SubmitAction->show()
#6 /srv/mediawiki/php-1.36.0-wmf.6/includes/MediaWiki.php(313): MediaWiki->performAction(Article, Title)
#7 /srv/mediawiki/php-1.36.0-wmf.6/includes/MediaWiki.php(940): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.36.0-wmf.6/includes/MediaWiki.php(543): MediaWiki->main()
#9 /srv/mediawiki/php-1.36.0-wmf.6/index.php(53): MediaWiki->run()
#10 /srv/mediawiki/php-1.36.0-wmf.6/index.php(46): wfIndexMain()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}

Subject	Repo	Branch	Lines +/-
EditPage: Fix member call on boolean when undo is impossible	mediawiki/core	wmf/1.36.0-wmf.6	+60 -1
EditPage: Fix member call on boolean when undo is impossible	mediawiki/core	wmf/1.36.0-wmf.8	+60 -1
EditPage: Fix member call on boolean when undo is impossible	mediawiki/core	master	+60 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMW824094428c5f: EditPage: Fix member call on boolean when undo is impossible

Event Timeline

daniel created this task.Sep 9 2020, 6:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2020, 6:55 PM

Reedy added a project: MediaWiki-Page-editing.Sep 9 2020, 7:01 PM

This code was added in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/616815.

Seen 58 times in the last 7 days.

Oh gee, my fault… will look into this ASAP.

Change 626226 had a related patch set uploaded (by Ostrzyciel; owner: Ostrzyciel):
[mediawiki/core@master] EditPage: Fix member call on boolean when undo is impossible

https://gerrit.wikimedia.org/r/626226

gerritbot added a project: Patch-For-Review.Sep 9 2020, 8:57 PM

Change 626226 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Fix member call on boolean when undo is impossible

https://gerrit.wikimedia.org/r/626226

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 10 2020, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 10 2020, 12:10 AM

matmarex closed this task as Resolved.Sep 10 2020, 1:55 AM

matmarex claimed this task.

matmarex reassigned this task from matmarex to Ostrzyciel.

Should we port it back to older wmf branches? Or is there no need to?

Change 626259 had a related patch set uploaded (by Ostrzyciel; owner: Ostrzyciel):
[mediawiki/core@wmf/1.36.0-wmf.8] EditPage: Fix member call on boolean when undo is impossible

https://gerrit.wikimedia.org/r/626259

gerritbot added a project: Patch-For-Review.Sep 10 2020, 12:50 PM

I wasn't going to do that because of the low volume of errors, but it won't hurt.

Change 626429 had a related patch set uploaded (by Urbanecm; owner: Ostrzyciel):
[mediawiki/core@wmf/1.36.0-wmf.6] EditPage: Fix member call on boolean when undo is impossible

https://gerrit.wikimedia.org/r/626429

Change 626259 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.8] EditPage: Fix member call on boolean when undo is impossible

https://gerrit.wikimedia.org/r/626259

Change 626429 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.6] EditPage: Fix member call on boolean when undo is impossible

https://gerrit.wikimedia.org/r/626429

Mentioned in SAL (#wikimedia-operations) [2020-09-10T18:37:36Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.6/includes/EditPage.php: rMW824094428c5f: EditPage: Fix member call on boolean when undo is impossible (T262463) (duration: 01m 07s)

Mentioned in SAL (#wikimedia-operations) [2020-09-10T18:40:03Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.8/includes/EditPage.php: rMW824094428c5f: EditPage: Fix member call on boolean when undo is impossible (T262463) (duration: 01m 03s)

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.6; 2020-08-25); removed MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 10 2020, 7:00 PM

Nintendofan885 removed a project: Patch-For-Review.Sep 13 2020, 3:48 PM

Call to a member function preSaveTransform() on booleanClosed, ResolvedPublicPRODUCTION ERRORActions