Uncaught TypeError: Cannot read property 'getMainText' of null (TypeError: config.title is null)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Jdlrobson
	Sep 9 2020, 7:43 PM

Description

Error

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.09.09/clienterror/?id=AXR0XkapMQ_08tQaNqcf
https://gerrit.wikimedia.org/g/mediawiki/core/+/dcc88f70f414afbdb52c901960aacc112f18770d/resources/src/mediawiki.widgets/mw.widgets.CategoryTagItemWidget.js#127

MediaWiki version: n/a

message

Uncaught TypeError: Cannot read property 'getMainText' of null

Impact

Notes

Details

Request ID: undefined
Request URL: https://commons.wikimedia.org/wiki/Special:UploadWizard

Stack Trace

exception.trace

at new MWWCategoryTagItemWidget  https://commons.wikimedia.org/w/load.php?lang=it&modules=...&skin=vector&version=wget3:1220:230
at MWCategoryMultiselectWidget.mw.widgets.CategoryMultiselectWidget.createTagItemWidget  https://commons.wikimedia.org/w/load.php?lang=it&modules=...&skin=vector&version=wget3:1224:281
at MWCategoryMultiselectWidget.UWCategoriesDetailsWidget.categoriesWidget.createTagItemWidget  https://commons.wikimedia.org/w/load.php?lang=it&modules=ext.uploadWizard%7Cext.uploadWizard.page&skin=vector&version=1gdgm:125:942
at MWCategoryMultiselectWidget.OO.ui.TagMultiselectWidget.addTag  https://commons.wikimedia.org/w/load.php?lang=it&modules=...&skin=vector&version=wget3:507:429
at MWCategoryMultiselectWidget.OO.ui.TagMultiselectWidget.addTagFromInput  https://commons.wikimedia.org/w/load.php?lang=it&modules=...&skin=vector&version=wget3:506:6
at MWCategoryMultiselectWidget.OO.ui.TagMultiselectWidget.onInputBlur  https://commons.wikimedia.org/w/load.php?lang=it&modules=...&skin=vector&version=wget3:503:267
at HTMLInputElement.dispatch  https://commons.wikimedia.org/w/load.php?lang=it&modules=...&skin=vector&version=wget3:69:742
at HTMLInputElement.elemData.handle  https://commons.wikimedia.org/w/load.php?lang=it&modules=...&skin=vector&version=wget3:66:388

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+11 -0	mw.widgets.CategoryMultiselectWidget: Fix exception on invalid input

Customize query in gerrit

Related Objects

Mentioned Here: rMW3ef6aa0728f6: mw.widgets.CategorySelector: Avoid JS exceptions for invalid user input
rMW3b6adf398722: mw.widgets.CategoryMultiselectWidget use TagMultiselectWidget

Event Timeline

Jdlrobson created this task.Sep 9 2020, 7:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2020, 7:43 PM

matmarex edited Stack Trace. (Show Details)Sep 14 2020, 8:06 PM

matmarex merged a task: T262840: TypeError: config.title is null at MWWCategoryTagItemWidget .

matmarex added a project: UploadWizard.

Jdlrobson renamed this task from Uncaught TypeError: Cannot read property 'getMainText' of null to Uncaught TypeError: Cannot read property 'getMainText' of null (TypeError: config.title is null).Sep 14 2020, 9:26 PM

Umherirrender added a project: JavaScript.Sep 16 2020, 7:19 PM

Jdlrobson moved this task from Untriaged to Older on the Wikimedia-production-error board.Sep 16 2020, 11:44 PM

Jdlrobson added a project: Structured-Data-Backlog.Oct 23 2020, 9:53 PM

CBogen moved this task from Triage to Needs Discussion on the Structured-Data-Backlog board.Oct 26 2020, 9:09 PM

Notes from a quick perusal of logstash: ~60 of these errors in the past 7 days, so not exactly a universal occurrence but not completely uncommon either. Unclear what effect this might have on the UI or if the users were able to circumvent the error somehow...in any case, I suspect this is something changing somewhere upstream and us needing to update the UW code. I feel like we've seen this bug before as well, but can't recall what exactly the issue was.

Marking as medium for now, but not sure whether this is severe enough for us to jump on it immediately (especially given likely disruptions throughout this month)

In T262466#6597534, @MarkTraceur wrote:

Notes from a quick perusal of logstash: ~60 of these errors in the past 7 days, so not exactly a universal occurrence but not completely uncommon either.

Note that this data does not currently include English Wikipedia (not sure if that's relevant here).

In T262466#6597546, @Jdlrobson wrote:

Note that this data does not currently include English Wikipedia (not sure if that's relevant here).

Well, UploadWizard isn't enabled on enwp so that makes sense :)

Jdlrobson awarded a token.Nov 2 2020, 6:20 PM

CBogen moved this task from Needs Discussion to Multimedia on the Structured-Data-Backlog board.Nov 9 2020, 3:41 PM

matmarex merged a task: T277122: Uncaught TypeError: Cannot read property 'getMainText' of null at new MWWCategoryTagItemWidget.Mar 12 2021, 11:12 PM

matmarex added a subscriber: matmarex.

To reproduce: input something that is not a valid page title in the "Categories" field, press Enter or Tab.

I was certain that I already fixed a similar issue years ago, and yes, rMW3ef6aa0728f6: mw.widgets.CategorySelector: Avoid JS exceptions for invalid user input fixes the same bug. It has been unfixed in rMW3b6adf398722: mw.widgets.CategoryMultiselectWidget use TagMultiselectWidget.

matmarex claimed this task.Mar 12 2021, 11:29 PM

Change 671306 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] mw.widgets.CategoryMultiselectWidget: Fix exception on invalid input

https://gerrit.wikimedia.org/r/671306

gerritbot added a project: Patch-For-Review.Mar 12 2021, 11:29 PM

Change 671306 merged by jenkins-bot:
[mediawiki/core@master] mw.widgets.CategoryMultiselectWidget: Fix exception on invalid input

https://gerrit.wikimedia.org/r/671306

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 13 2021, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2021, 7:10 PM

matmarex closed this task as Resolved.Mar 14 2021, 1:43 PM