Page MenuHomePhabricator

Convert EnhanceContactForm to use extension registration
Open, Needs TriagePublic

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Adding ShoutWiki so team can help with this task.

Also, I think that we should make "text" translatable, instead of hard-coding English one.

Kizule changed the task status from Open to Stalled.Sep 10 2020, 4:55 PM

Stailed until we resolve these questions.

The HHVM line was added in rEECF368626cd6ede32b0c31779a95a0d51bd81da5c89 by @ashley four years ago.

HHVM support got dropped in MediaWiki Core in T192166, however I don't know the Compatibility policy of this extension as it is not listed on https://www.mediawiki.org/wiki/Extension:EnhanceContactForm

Like with other ShoutWiki maintained extensions, the compatibility policy is basically "latest stable version OR the version used by ShoutWiki with the latter given preference should these two differ". If and when HHVM support is gone, code related to it can safely be removed from here. Obviously things change quite a bit in 4 years. :)

That said, I'm of course willing to review any and all patches, but this isn't a high-priority issue for a variety of reasons, including but not limited to the fact that we currently don't use EnhanceContactForm on ShoutWiki as MediaWiki-extensions-ContactPage is also currently disabled on ShoutWiki and EnhanceContactForm is an extension of ContactPage.

Also, I think that we should make "text" translatable, instead of hard-coding English one.

As a general rule of thumb, this is a good idea, though exceptions exist, and I'd say you've stumbled upon one. So EnhanceContactForm modifies the message sent by the user via the Special:Contact form by adding in more details, which we (ShoutWiki staff) can use to better help our users in debugging issues they may stumble upon; i.e. browser-specific bugs, bugs present only on a certain wiki due to its custom configuration, and so on. Just like in MediaWiki development, the language we all speak and understand well is English. Translating the text that gets sent to us to a language that we potentially don't even speak would not really be helpful (although we can of course figure out things).

Kizule changed the task status from Stalled to Open.Sep 24 2020, 6:37 PM
Kizule removed Kizule as the assignee of this task.
Kizule moved this task from Inbox to Watching on the User-Kizule board.

Thanks for responds! I'm unclaiming task as this isn't high-priority issue, and also extension is unused as you said.