Page MenuHomePhabricator
Create Task
Maniphest T262487

Uncaught TypeError: Cannot read property 'childNodes' of null
Closed, ResolvedPublic
Actions

Description

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.09.09/clienterror/?id=AXRwQthi3_NNwgAUoENN
Occuring during mobile editing

at VeCeDocument.ve.ce.Document.getNodeAndOffset  <URL1>:437:674
at VeCeSurface.ve.ce.Surface.annotationsAtModelSelection  <URL1>:564:94
at VeCeSurface.ve.ce.Surface.onDocumentMouseDown  <URL1>:504:404
at HTMLElement.dispatch  <URL2>:69:742
at HTMLElement.elemData.handle  <URL2>:66:388

URL1=https://m.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2Cdiffing%2Cicons%2Clanguage%2Cmediawiki%2CmobileArticleTarget%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2CsupportCheck%2Cwelcome%7Cext.visualEditor.core.mobile%2Cutils%7Cext.visualEditor.mwimage.core&skin=minerva&version=w4h7t
URL2=https://m.mediawiki.org/w/load.php?lang=en&modules=jquery%2Csite&skin=minerva&version=znizl

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (8b37f95f1)mediawiki/extensions/VisualEditormaster+1 -1
Catch errors from getNodeAndOffset in ve.ce.Surface#focusVisualEditor/VisualEditormaster+10 -3
Update VE core submodule to master (53af216aa)mediawiki/extensions/VisualEditormaster+23 -15
Catch errors from getNodeAndOffset in annotationsAtModelSelectionVisualEditor/VisualEditormaster+14 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Sep 9 2020, 10:21 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptSep 9 2020, 10:21 PM
JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.Sep 10 2020, 4:28 PM
JTannerWMF added a project: Editing-team (Kanban Board).
JTannerWMF moved this task from Incoming to Upcoming on the Editing-team (Kanban Board) board.Sep 10 2020, 4:30 PM
Esanders updated the task description. (Show Details)Sep 11 2020, 11:04 AM
Jdlrobson moved this task from Untriaged to Older on the Wikimedia-production-error board.Sep 16 2020, 6:57 PM
Umherirrender added a project: JavaScript.Sep 16 2020, 7:35 PM
gerritbot added a comment.Sep 17 2020, 12:03 PM

Change 628076 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in annotationsAtModelSelection

https://gerrit.wikimedia.org/r/628076

gerritbot added a project: Patch-For-Review.Sep 17 2020, 12:03 PM
Esanders moved this task from Upcoming to Code Review on the Editing-team (Kanban Board) board.Sep 17 2020, 12:04 PM
Esanders added subscribers: dchan, Esanders.Sep 17 2020, 12:13 PM

This one is a bit concerning because it isn't from a throw, so we should still see if we can reproduce this somehow. CC @dchan

gerritbot added a comment.Sep 17 2020, 12:14 PM

Change 628076 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in annotationsAtModelSelection

https://gerrit.wikimedia.org/r/628076

gerritbot added a comment.Sep 17 2020, 12:21 PM

Change 628077 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (53af216aa)

https://gerrit.wikimedia.org/r/628077

gerritbot added a comment.Sep 17 2020, 6:20 PM

Change 628077 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (53af216aa)

https://gerrit.wikimedia.org/r/628077

Maintenance_bot removed a project: Patch-For-Review.Sep 17 2020, 7:10 PM
matmarex moved this task from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Sep 17 2020, 7:25 PM
matmarex subscribed.

Instead of QA, we should check the logs to confirm this error has disappeared after the patches are deployed.

matmarex moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.Oct 2 2020, 2:56 AM

Still occurring: https://logstash.wikimedia.org/goto/406701b96f5df137c8dc46bbcc98f36e

image.png (405×2 px, 43 KB)

• ppelberg added a parent task: T264487: Confirm client-side errors are no longer occurring .Oct 3 2020, 1:42 AM
JTannerWMF removed projects: JavaScript, Editing-team (Kanban Board), Wikimedia-production-error, VisualEditor, VisualEditor-MediaWiki-Mobile.Oct 14 2020, 3:08 PM
JTannerWMF added projects: VisualEditor, Wikimedia-production-error, JavaScript, Editing-team (Tracking).Oct 14 2020, 3:14 PM
matmarex edited projects, added Editing-team (Kanban Board), VisualEditor-MediaWiki-Mobile; removed Editing-team (Tracking).Oct 14 2020, 3:26 PM
gerritbot added a comment.Nov 9 2020, 10:46 AM

Change 640091 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in ve.ce.Surface#focus

https://gerrit.wikimedia.org/r/640091

gerritbot added a project: Patch-For-Review.Nov 9 2020, 10:47 AM
matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Nov 9 2020, 10:48 AM
gerritbot added a comment.Nov 11 2020, 11:00 PM

Change 640091 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in ve.ce.Surface#focus

https://gerrit.wikimedia.org/r/640091

Maintenance_bot removed a project: Patch-For-Review.Nov 11 2020, 11:10 PM
Esanders assigned this task to matmarex.Nov 14 2020, 2:39 PM
Esanders moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.
Esanders added a project: Skipped QA.
gerritbot added a comment.Nov 16 2020, 10:27 PM

Change 641268 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b37f95f1)

https://gerrit.wikimedia.org/r/641268

gerritbot added a project: Patch-For-Review.Nov 16 2020, 10:27 PM
gerritbot added a comment.Nov 16 2020, 10:55 PM

Change 641268 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b37f95f1)

https://gerrit.wikimedia.org/r/641268

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.18; 2020-11-17).Nov 16 2020, 11:01 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 16 2020, 11:10 PM
• ppelberg closed this task as Resolved.Nov 17 2020, 2:50 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 17 2020, 2:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL