In push notifications service the default value for spec is documented as ./spec.yaml. Because of typescript compilation the default value points to dist/loaders/spec.yml since we are locating the file using __dirname. This causes the default config not being able to render the spec document since it defaults to a non-existing file.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix default value handling for app.conf.spec | mediawiki/services/push-notifications | master | +2 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jgiannelos | T250452 New Service Request: Wikimedia push notification service | |||
| Resolved | jijiki | T256973 Deploy push-notifications service to Kubernetes | |||
| Resolved | MSantos | T261635 Test push-notifications service in the staging environment | |||
| Resolved | Jgiannelos | T262528 Misleading default value for push notifications `spec` config entry |
Event Timeline
Comment Actions
Change 626360 had a related patch set uploaded (by Jgiannelos; owner: Jgiannelos):
[mediawiki/services/push-notifications@master] Fix default value handling for app.conf.spec
Comment Actions
Change 626360 merged by jenkins-bot:
[mediawiki/services/push-notifications@master] Fix default value handling for app.conf.spec