Maniphest T262565

Complete the transition of ExampleSkin to SkinMustache
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Sep 10 2020, 4:31 PM

Project Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

Acceptance criteria

includes/ExampleTemplate should no longer exist.
messages feature will be used for messages
Menu's data is provided by core (blocked on T262098)
The skin uses the recommended features for ResourceLoaderSkinModule
There are no unreferenced template variables

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Use new opt-in policy mode	Ammarpad	mediawiki/skins/Example	master	+7 -7
	Drop unused template variable	Jdlrobson	mediawiki/skins/Example	master	+0 -1
	Migrate more code to SkinMustache	Jdlrobson	mediawiki/skins/Example	master	+44 -137

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T235008 ExampleSkin should use SkinMustache
		Resolved		None	T262565 Complete the transition of ExampleSkin to SkinMustache

Event Timeline

Jdlrobson created this task.Sep 10 2020, 4:31 PM

Jdlrobson mentioned this in T235008: ExampleSkin should use SkinMustache.

Jdlrobson moved this task from Backlog to Milestone: More flexibility in article heading area (subpages, descriptions) on the MediaWiki-Core-Skin-Architecture board.Sep 10 2020, 9:27 PM

Change 626504 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Example@master] Migrate more code to SkinMustache

https://gerrit.wikimedia.org/r/626504

gerritbot added a project: Patch-For-Review.Sep 10 2020, 9:28 PM

Change 626504 merged by jenkins-bot:
[mediawiki/skins/Example@master] Migrate more code to SkinMustache

https://gerrit.wikimedia.org/r/626504

Jdlrobson mentioned this in rSEXAMPLEa5ea2b6f2852: Migrate more code to SkinMustache.Sep 18 2020, 4:40 AM

Jdlrobson mentioned this in rSEXAa5ea2b6f2852: Migrate more code to SkinMustache.Sep 18 2020, 4:47 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 18 2020, 5:10 AM

Change 631395 had a related patch set uploaded (by Jdlrobson; owner: Ammarpad):
[mediawiki/skins/Example@master] Turn on RL SkinModule legacy feature

https://gerrit.wikimedia.org/r/631395

gerritbot added a project: Patch-For-Review.Oct 1 2020, 7:56 PM

Change 631862 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Example@master] Drop unused template variable

https://gerrit.wikimedia.org/r/631862

Jdlrobson updated the task description. (Show Details)Oct 2 2020, 8:11 PM

Change 631862 merged by jenkins-bot:
[mediawiki/skins/Example@master] Drop unused template variable

https://gerrit.wikimedia.org/r/631862

Jdlrobson mentioned this in rSEXAMPLEf6022d0e6966: Drop unused template variable.Oct 7 2020, 2:36 PM

Jdlrobson mentioned this in rSEXAf6022d0e6966: Drop unused template variable.Oct 7 2020, 3:08 PM

Jdlrobson updated the task description. (Show Details)Oct 7 2020, 4:03 PM

Jdlrobson moved this task from Milestone: More flexibility in article heading area (subpages, descriptions) to Phase 3 - standardise template data on the MediaWiki-Core-Skin-Architecture board.Nov 5 2020, 7:50 PM

Jdlrobson closed this task as Resolved.Nov 17 2020, 10:40 PM

Jdlrobson updated the task description. (Show Details)

Change 631395 merged by jenkins-bot:
[mediawiki/skins/Example@master] Use new opt-in policy mode

https://gerrit.wikimedia.org/r/631395

Jdlrobson mentioned this in rSEXAc939e4251cb6: Use new opt-in policy mode.Nov 17 2020, 11:07 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 17 2020, 11:11 PM

Jdlrobson mentioned this in rSEXAMPLEc939e4251cb6: Use new opt-in policy mode.Nov 17 2020, 11:11 PM