Page MenuHomePhabricator

Non-functional reply links appear for some messages wrapped in <div>
Closed, ResolvedPublic

Description

Non-functional reply links appear for some messages wrapped in <div>.

Example: https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Yatu

Note how when you click "reply", the placeholder text is "Reply to Yatu" instead of "Reply to Test". Something goes very wrong, and the wrong username comes from the "edit source" link on the sub-heading rather than from the actual signature. (And then the reply can't be saved, because we can't find any comment by "Yatu" on the page.)

There should be no reply link at all, because the timestamp is on a different line of text than the user page links.

Originally reported here: https://www.mediawiki.org/wiki/Topic:Vt5zo2ibvrkzfnxj

Event Timeline

This will be moved to triaged once that column is created

I have actually already figured out the issue here, just haven't found the time to write down the solution ;)

Change 630940 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix detecting username from the wrong links sometimes

https://gerrit.wikimedia.org/r/630940

There should be no reply link at all, because the timestamp is on a different line of text than the user page links.

Well, there will actually be a reply link with that patch, but it will work this time. I think it's not worth the effort to try to get rid of it (although ideally the behavior would be consistent).

Change 630940 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix detecting username from the wrong links sometimes

https://gerrit.wikimedia.org/r/630940

ppelberg added a project: Skipped QA.