Drop support for the deprecated mobileview "noimages" api parameter
Closed, ResolvedPublic
Actions

Description

The deprecated mobileview api has a parameter noimages which allows removal of images from the page. It makes use of the RemoveImagesTransform

As we are refactoring MobileFormatter this codes adds some unnecessary challenges that make continued support too expensive.

Rather than continue to support this, let's remove this parameter and associated code.

https://en.wikipedia.org/wiki/Special:ApiSandbox#action=mobileview&format=json&page=Spain&prop=text%7Csections%7Cnormalizedtitle&noimages=1

acceptance criteria

Remove the noimages transform
RemoveImagesTransform has been removed
Announce the change on mediawiki-api-announce@ and mediawiki-api@

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove noImages parameter from mobile API and all its artifacts	mediawiki/extensions/MobileFrontend	master	+4 -145

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50%
Resolved	Jdlrobson	T186627 Remove the MobileView API
Resolved	Jdlrobson	T262580 Drop support for the deprecated mobileview "noimages" api parameter

Event Timeline

Jdlrobson created this task.Sep 10 2020, 7:19 PM

Change 626593 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/MobileFrontend@master] Remove noImages parameter from mobile API and all its artifacts

https://gerrit.wikimedia.org/r/626593

gerritbot added a project: Patch-For-Review.Sep 11 2020, 7:57 AM

Peter.ovchyn claimed this task.Sep 11 2020, 7:58 AM

Peter.ovchyn mentioned this in T261769: MobileFormatter follow up work.Sep 11 2020, 8:03 AM

phuedx updated the task description. (Show Details)Sep 11 2020, 9:18 AM

According to sampled page view traffic usage was pretty low and it appears the parameter had no effect on action=parse:
https://turnilo.wikimedia.org/#webrequest_sampled_128/4/N4IgbglgzgrghgGwgLzgFwgewHYgFwhpwBGCApiADTjTxKoY4DKZaG2A5lPqAMaYIEcAA5QyAJUwB3bngBmiMQF9qGALZlkOCgQCiaXgHoAqgBUAwlRByICNGQBOsgNqg0AT2E7CEDVYdkcvggAPoh6hSqvmQACo5YACYuoAkwDuhYuAQxAIwAIlZQ9sL4ALQ5qp7eQvZFIEoAuipuVcFFDhCc/oHBaRAhAI4wju5WcLyMWSD82ESd3NRgiMMuINiYvnAcZFAAvCAN1Oto+AoIyocgUMJIaMmErQTtnRxWCdHYUJnBECXUUJgHCc8KAAkECAALCB3KweLxteI7N4QAITb4EBI7XhkbDvLrULwdTAJYL1ahINTQ/AAVgADI1/oj7mDHDjscEoTDqHJAWp0DwHvCMYE4DA7FYlghhqSVILvBo4LAAvVLsJOtgyAk8h8vjgXKr1ZqmIDgSBOdwlEA==

Wikimedia apps are not relying on this parameter so I think we are good to go here.
I've emailed the appropriate mailing lists. Would be great if someone could confirm they sent correctly.

Change 626593 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove noImages parameter from mobile API and all its artifacts

https://gerrit.wikimedia.org/r/626593

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 11 2020, 9:00 PM

Peter.ovchyn reassigned this task from Peter.ovchyn to Jdlrobson.Sep 14 2020, 5:06 PM

Peter.ovchyn subscribed.

• JMinor unsubscribed.Sep 14 2020, 5:35 PM

The noimages parameter is no more and the announcement email went through (finally):
https://lists.wikimedia.org/pipermail/mediawiki-api/2020-September/004265.html

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2020, 1:30 AM

Stang unsubscribed.Nov 13 2021, 11:29 PM

Drop support for the deprecated mobileview "noimages" api parameterClosed, ResolvedPublicActions