Page MenuHomePhabricator
Create Task
Maniphest T262697

Make LESS files work more seamlessly across size boundaries
Closed, ResolvedPublic
Actions

Description

Currently, as the browser window is resized, the navigation elements tend to jump around more than they need to. Also, some elements are hard-coded to specific pixel sizes, which makes them less responsive. The following items should be accomplished:

  • To follow best practices for CSS, convert all px units used in the skin to rem units. This is a follow up to T260306.
  • Eliminate the svg files in favor of OOUI icons where possible.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Eliminate svg files in favor of OOUI iconsmediawiki/skins/WikimediaApiPortalmaster+96 -523
Convert px to rem unitsmediawiki/skins/WikimediaApiPortalmaster+129 -129
Customize query in gerrit

Related Objects

Event Timeline

apaskulin created this task.Sep 11 2020, 5:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2020, 5:15 PM
apaskulin mentioned this in T260700: Notification indicator out of place at narrower width.Sep 14 2020, 7:26 PM
• CCicalese_WMF renamed this task from Convert px units to rem to Make LESS files work more seamlessly across size boundaries.Sep 15 2020, 4:13 PM
• CCicalese_WMF updated the task description. (Show Details)
• WDoranWMF added a project: Platform Team Workboards (Green).Sep 16 2020, 3:15 PM
• WDoranWMF moved this task from Backlog to Ready on the Platform Team Workboards (Green) board.
apaskulin assigned this task to • Clarakosi.Sep 16 2020, 3:58 PM
• Clarakosi moved this task from Ready to Doing on the Platform Team Workboards (Green) board.Sep 16 2020, 9:02 PM
gerritbot added a comment.Sep 17 2020, 8:02 PM

Change 628188 had a related patch set uploaded (by Clarakosi; owner: Clarakosi):
[mediawiki/skins/WikimediaApiPortal@master] WIP Update Less files to be more responsive

https://gerrit.wikimedia.org/r/628188

gerritbot added a project: Patch-For-Review.Sep 17 2020, 8:02 PM
• WDoranWMF moved this task from Doing to Waiting for Review on the Platform Team Workboards (Green) board.Sep 18 2020, 4:09 PM
gerritbot added a comment.Sep 18 2020, 5:40 PM

Change 628411 had a related patch set uploaded (by Clarakosi; owner: Clarakosi):
[mediawiki/skins/WikimediaApiPortal@master] Eliminate the svg files in favor of OOUI icons

https://gerrit.wikimedia.org/r/628411

gerritbot added a comment.Sep 23 2020, 6:12 PM

Change 628188 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] Convert px to rem units

https://gerrit.wikimedia.org/r/628188

• Clarakosi updated the task description. (Show Details)Sep 23 2020, 6:56 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 23 2020, 7:00 PM
gerritbot added a comment.Sep 23 2020, 8:09 PM

Change 628411 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] Eliminate svg files in favor of OOUI icons

https://gerrit.wikimedia.org/r/628411

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2020, 8:10 PM
• Clarakosi updated the task description. (Show Details)Sep 23 2020, 8:12 PM
Volker_E awarded a token.Sep 24 2020, 11:17 AM
apaskulin mentioned this in T264041: Improve consistency of LESS files.Sep 28 2020, 7:47 PM

Moved issues with LESS file consistency to T264041

apaskulin closed this task as Resolved.Sep 28 2020, 7:47 PM
apaskulin updated the task description. (Show Details)
apaskulin moved this task from Waiting for Review to Done on the Platform Team Workboards (Green) board.

Verified on beta. Thanks, Clara!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits