GWToolset needs uses of global $wgUser removed
Closed, ResolvedPublic
Actions

Description

See parent task for reasoning

Used in UploadMediafileJob.php

Codesearch: https://codesearch.wmcloud.org/deployed/?q=global%5B%5E%3B%5D%2B%5C%24wgUser%5B%2C%3B%5D&i=nope&files=&repos=mediawiki/extensions/GWToolset

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	UploadMediafileJob: Remove use of $wgUser	mediawiki/extensions/GWToolset	master	+1 -13

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	MGChecker	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Resolved	DannyS712	T245959 WMF deployed extensions need uses of global $wgUser removed [tracking]
Resolved	DannyS712	T262713 GWToolset needs uses of global $wgUser removed

Event Timeline

DannyS712 created this task.Sep 11 2020, 7:03 PM

Restricted Application added a project: Commons. · View Herald TranscriptSep 11 2020, 7:03 PM

DannyS712 triaged this task as Medium priority.Sep 11 2020, 7:03 PM

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.Sep 11 2020, 7:13 PM

Change 647073 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GWToolset@master] UploadMediafileJob: Remove use of $wgUser

https://gerrit.wikimedia.org/r/647073

gerritbot added a project: Patch-For-Review.Dec 9 2020, 12:50 AM

DannyS712 added a project: Platform Team Workboards (External Code Reviews).Dec 9 2020, 1:03 AM

• Clarakosi moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.Dec 14 2020, 8:04 PM

Change 647073 merged by jenkins-bot:
[mediawiki/extensions/GWToolset@master] UploadMediafileJob: Remove use of $wgUser

https://gerrit.wikimedia.org/r/647073

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2020, 8:11 PM

DannyS712 closed this task as Resolved.Dec 14 2020, 8:45 PM

DannyS712 claimed this task.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 14 2020, 9:00 PM