Page MenuHomePhabricator

Date data input separator "." no longer parsed correctly
Closed, DeclinedPublic

Description

Date data input separator "." is not longer parsed correctly. Bug appeared some time ago. I first nottied it on pl.wikipedia.org (1 -2 weeks ago), now it's also on en.wikipedia.org, Mediawiki and Vega 2 editor. When graph is generated by Graphoid date is parsed correctly and graph is generated as expected, please see my sandbox.

Existing output


debug from Vega 2 editor shows that d3 parse of input is null

Expected output

Vega 2 JSON for example above

{
  "width": 200,
  "height": 200,
  "scales": [
    {
      "type": "time",
      "name": "x",
      "domain": {"data": "chart","field": "x"},
      "range": "width",
      "zero": false
    },
    {
      "type": "linear",
      "name": "y",
      "domain": {"data": "chart","field": "y"},
      "zero": false,
      "range": "height",
      "nice": true
    }
  ],
  "marks": [
    {
      "type": "line",
      "properties": {
        "enter": {
          "y": {"scale": "y","field": "y"},
          "x": {"scale": "x","field": "x"},
          "stroke": {"value": "black"}
        }
      },
      "from": {"data": "chart"}
    }
  ],
  "axes": [{"type": "x","scale": "x"},{"type": "y","scale": "y"}],
  "data": [
    {
      "format": {"parse": {"y": "integer","x": "date"},"type": "json"},
      "name": "chart",
      "values": [
        {"y": 1,"series": "y","x": "1.10.2020"},
        {"y": 2,"series": "y","x": "2.10.2020"},
        {"y": 3,"series": "y","x": "3.10.2020"}
      ]
    }
  ]
}

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2020, 11:40 AM
Pietrasagh closed this task as Declined.Sep 15 2020, 11:01 AM
Pietrasagh triaged this task as Lowest priority.

It seems to be browser related ("." works in chrome but not in firefox). Maybe graphoid use same libs as chrome/ium
See Vega issue

Pietrasagh updated the task description. (Show Details)Sep 16 2020, 5:33 PM