VE hangs when editing reference
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RoySmith
	Sep 13 2020, 3:02 PM

Description

MacOS 10.13.6
Chrome Version 85.0.4183.102 (Official Build) (64-bit)

I'm editing https://en.wikipedia.org/w/index.php?title=User:RoySmith/drafts/Robert_Weinberg_(urban_planner)&oldid=978201279. I've just added a reference, and when I go to save it, it hangs in the edit box. Hitting either the Apply Change or the X button have no effect, but I'm able to dismiss the edit box by typing ESC.

In the javascript console. I've got:

Uncaught TypeError: Cannot read property 'isReadOnly' of null
    at VeDmMWTransclusionInlineNode.ve.dm.Node.getOffset (load.php?lang=en&modules=ext.visualEditor.core&skin=vector&version=64but:55)
    at VeDmMWTransclusionInlineNode.ve.Node.getOuterRange (load.php?lang=en&modules=ext.visualEditor.core&skin=vector&version=64but:6)
    at VeDmMWTransclusionModel.ve.dm.MWTransclusionModel.updateTransclusionNode (<anonymous>:511:402)
    at <anonymous>:367:175
    at fire (load.php?lang=en&modules=jquery%2Coojs-ui-core|jquery.ui&skin=vector&version=1rnvg:46)
    at Object.add [as done] (load.php?lang=en&modules=jquery%2Coojs-ui-core|jquery.ui&skin=vector&version=1rnvg:46)
    at <anonymous>:366:411
    at <anonymous>:16:96
    at OO.ui.Process.execute (<anonymous>:16:754)
    at VeUiMWCitationDialog.OO.ui.Dialog.executeAction (<anonymous>:40:46)

Screenshot attached.

Screen Shot 2020-09-13 at 10.56.22 AM.png (2×2 px, 1 MB)

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (53af216aa)	mediawiki/extensions/VisualEditor	master	+23 -15
	ve.dm.Node: Check if attached before accessing document	VisualEditor/VisualEditor	master	+4 -4

Customize query in gerrit

Related Objects

Mentioned Here: rGVED53af216aa899: Merge "jsduck: Add UI classes to Diffing category"

Event Timeline

RoySmith created this task.Sep 13 2020, 3:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2020, 3:02 PM

Probably caused by https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/623810

Change 627292 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.dm.Node: Check if attached before accessing document

https://gerrit.wikimedia.org/r/627292

gerritbot added a project: Patch-For-Review.Sep 14 2020, 2:36 PM

matmarex claimed this task.Sep 14 2020, 2:36 PM

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Does this need a backport?

Change 627292 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.dm.Node: Check if attached before accessing document

https://gerrit.wikimedia.org/r/627292

Esanders moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 16 2020, 10:58 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2020, 11:10 PM

In T262758#6468546, @Esanders wrote:

Does this need a backport?

Probably not, seems like a very low volume of errors (Logstash finds exactly 1 result ever: https://logstash.wikimedia.org/goto/3047fa1c3cbbd5669a3487680fb5dcd3), and I couldn't reproduce on the linked page either.

Change 628077 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (53af216aa)

https://gerrit.wikimedia.org/r/628077

gerritbot added a project: Patch-For-Review.Sep 17 2020, 12:21 PM

Change 628077 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (53af216aa)

https://gerrit.wikimedia.org/r/628077

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 17 2020, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 17 2020, 7:10 PM

matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 17 2020, 7:19 PM

matmarex added a project: Skipped QA.

• ppelberg closed this task as Resolved.Sep 21 2020, 1:10 AM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 21 2020, 1:10 AM