Page MenuHomePhabricator
Create Task
Maniphest T262762

Accept and handle sites with a protocol
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Should Special:GlobalWatchlistSettings accepts sites in the form http://en.wikipedia.org rather than en.wikipedia.org? Same for https.

Benefits:
User can just copy the url from another tab with the site open

Drawbacks:
Requires extra handling

Details

SubjectRepoBranchLines +/-
Settings: Accept sites with a protocol, object to duplicate sitesmediawiki/extensions/GlobalWatchlistmaster+71 -21
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Sep 13 2020, 5:10 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 13 2020, 5:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as Low priority.Sep 13 2020, 5:11 PM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 set the point value for this task to 2.

If these are accepted, they should be normalized when saving settings, to ensure that they are consistent for the javascript on Special:GlobalWatchlist and to remove storing unneeded protocols in the database (unless the protocol should be enforced?)

gerritbot added a comment.Feb 1 2021, 9:04 PM

Change 660932 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Settings: Accept sites with a protocol, object to duplicate sites

https://gerrit.wikimedia.org/r/660932

gerritbot added a project: Patch-For-Review.Feb 1 2021, 9:04 PM
DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.Feb 1 2021, 9:19 PM
DannyS712 moved this task from Backlog to In progress on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 claimed this task.Feb 1 2021, 9:45 PM
gerritbot added a comment.Feb 2 2021, 10:32 PM

Change 660932 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Settings: Accept sites with a protocol, object to duplicate sites

https://gerrit.wikimedia.org/r/660932

jenkins-bot mentioned this in rEGLWf6dc1bb9c3f4: Settings: Accept sites with a protocol, object to duplicate sites.Feb 2 2021, 10:42 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 2 2021, 11:11 PM
DannyS712 closed this task as Resolved.Feb 2 2021, 11:24 PM
DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set Final Story Points to 2.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL