Page MenuHomePhabricator

Uncaught TypeError: Cannot read property 'node' of null (in importTable )
Closed, ResolvedPublic

Description

Was not fixed by T261530 but looks related.
https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.09.14/clienterror/?id=AXSNzH2aMQ_08tQacf40

at VeUiTableAction.ve.ui.TableAction.importTable  URL1:690:492
at VeCeSurface.ve.ce.Surface.afterPasteAddToFragmentFromExternal  URL1:467:105
at VeCeSurface.ve.ce.Surface.afterPaste  URL1:460:692
at URL1:456:510

URL1: https://he.wikipedia.org/w/load.php?lang=he&modules=ext.visualEditor.core&skin=vector&version=mc4q2

Event Timeline

Jdlrobson renamed this task from Uncaught TypeError: Cannot read property 'node' of null to Uncaught TypeError: Cannot read property 'node' of null (in importTable ).Sep 14 2020, 6:11 PM

Line 319: if ( importedCell.node.type !== cell.node.type ) {

Could be pasting a sparse table...

The logstash board has been updated to filter this error out by default as logspam. Remember to disable/remove that rule when viewing frequency/checking if it's fixed.

Error also appears as "TypeError: null is not an object (evaluating 'importedCell.node')"

Change 677245 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Ignore missing matrix cell when importing

https://gerrit.wikimedia.org/r/677245

Change 677245 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Ignore missing matrix cell when importing

https://gerrit.wikimedia.org/r/677245

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Will be considered fixed if the errors stop happening

Change 677670 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (83f89605d)

https://gerrit.wikimedia.org/r/677670

Change 677670 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (83f89605d)

https://gerrit.wikimedia.org/r/677670

No results in last 24hr. Have removed the filter.